Project

General

Profile

Actions

Bug #55299

closed

conflictMode rename is not working when uploading file with umlaut

Added by Eike Starkmann about 10 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
File Abstraction Layer (FAL)
Target version:
-
Start date:
2014-01-24
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.1
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

To reproduce this:

Upload a file called Müller.jpg via

$file = $folder->getStorage()->addUploadedFile($fileUpload->getFileUploadArray(), $folder, NULL, $conflictMode);

Then again upload a file called Müller.jpg. Normally FAL should create a file called Müller_01.jpg (Mueller_01.jpg).
Erroneously the original file will be overwritten.

The problem is, that FAL checks if Müller.jpg exits, but this file does not exist because it will be renamed in Mueller.jpg after upload.
So FAL uploads the new file, renames it in Mueller.jpg and the original file is overwritten.


Files

filenames_different.jpg (70.6 KB) filenames_different.jpg Patch works, but filename is displayed differently Markus Klein, 2014-02-26 23:06

Related issues 2 (0 open2 closed)

Related to TYPO3 Core - Bug #56181: FAL can't handle folder names starting with umlauts properlyClosed2014-02-21

Actions
Related to TYPO3 Core - Bug #54357: Inconsistent usage of filename sanitationClosed2013-12-12

Actions
Actions #1

Updated by Frans Saris about 10 years ago

  • Status changed from New to Accepted

In ResourceStorage->addFile() we need to call driver->sanitizeFileName() before calling driver->fileExistsInFolder()

Actions #2

Updated by Gerrit Code Review about 10 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27806

Actions #3

Updated by Gerrit Code Review about 10 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27806

Actions #5

Updated by Gerrit Code Review about 10 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27806

Actions #6

Updated by Gerrit Code Review about 10 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27806

Actions #7

Updated by Frans Saris about 10 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #8

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF