Project

General

Profile

Actions

Feature #55355

closed

Check if file exists before outputing

Added by Tizian Schmidlin over 10 years ago. Updated over 8 years ago.

Status:
Rejected
Priority:
Won't have this time
Assignee:
-
Category:
Indexed Search
Target version:
Start date:
2014-01-27
Due date:
% Done:

0%

Estimated time:
PHP Version:
5.3
Tags:
Complexity:
Sprint Focus:

Description

Hello there,

it often happens in bigger systems, that folder structures and filenames change or are deleted on a regular basis. In both cases there is no way to communicate this properly to indexed search (since these changes might happen through the system directly without using TYPO3).

This leads to errornous results in the indexed search and is really frustrating for users and clients.

To avoid this, I figured that you could simply check if the file exists while creating the results array in class.tx_indexedsearch.php like this:

file: typo3/sysext/indexed_search/pi/class.tx_indexedsearch.php
TYPO3 Version: 4.5.27
Begins: line 606

    if($row['data_filename'] != '' && !file_exists(PATH_site . $row['data_filename'])) {
        $count--;
        continue;
    }
Actions #1

Updated by Markus Klein over 10 years ago

Hi Tizian!

Thanks for your report. Feel free to supply a patch to our review system.
For further instructions please refer to http://wiki.typo3.org/CWT
(Important: The patch has to be filed for current master)

Actions #2

Updated by Mathias Schreiber over 9 years ago

  • Target version set to 7.5

I not sure how to deal with this one.
Checking these will pull down the sub-par performance of IS even more.

Actions #3

Updated by Benni Mack over 8 years ago

  • Target version changed from 7.5 to 7 LTS
Actions #4

Updated by Tymoteusz Motylewski over 8 years ago

  • Priority changed from Should have to Won't have this time

Hi Tizian Schmidlin
Sorry, but it will not be changed.
We have to assume that data stored in index is valid.
If data changes we need to update index.

Actions #5

Updated by Tymoteusz Motylewski over 8 years ago

  • Status changed from New to Rejected
Actions

Also available in: Atom PDF