Project

General

Profile

Actions

Task #55573

closed

Epic #55070: Workpackages

Epic #54851: WP: Workspaces IRRE & MM bugfixes

Story #54853: As a user I want to correctly create, modify, preview and publish IRRE & MM related workspace changes

Failing moveContentRecordToDifferentPageAndChangeSorting

Added by Oliver Hader almost 11 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Workspaces
Target version:
Start date:
2014-02-02
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
5.3
Tags:
Complexity:
Sprint Focus:

Description

TYPO3\CMS\Workspaces\Tests\Functional\DataHandling\Regular::moveContentRecordToDifferentPageAndChangeSorting fails (see #55563)

In a workspace, an existing content record is moved to an existing page. Another existing record is moved after the previously moved record on the target page. The Functional Tests show, that the content records are faulty after the processing and the first content record disappeared.


Related issues 4 (0 open4 closed)

Related to TYPO3 Core - Task #55563: Add functional test cases to DataHandler for regular workspace editingClosedOliver Hader2014-02-01

Actions
Related to TYPO3 Core - Bug #33104: create/move initial-placeholder page behind move-placeholder page broken.Closed2012-01-11

Actions
Related to TYPO3 Core - Bug #53619: Moving Elements in draft - now my live is a messClosed2013-11-13

Actions
Has duplicate TYPO3 Core - Bug #55768: Drag & drop in Workspaces moves live pageClosedThorsten Kahler2014-02-07

Actions
Actions #1

Updated by Oliver Hader almost 11 years ago

  • Assignee set to Oliver Hader
  • Parent task set to #54853
Actions #2

Updated by Oliver Hader almost 11 years ago

  • Is Regression changed from No to Yes
Actions #3

Updated by Oliver Hader almost 11 years ago

The behaviour is caused by #33104 which has a wrong fix and seems to be related to pages only (but affects currently all tables)

Actions #4

Updated by Gerrit Code Review almost 11 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27733

Actions #5

Updated by Gerrit Code Review almost 11 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27733

Actions #6

Updated by Oliver Hader almost 11 years ago

A similar behaviour has been discovered for pages which finally lead to the regression causing this bug in issue #33104. Back then a hook has been introduced for moving page records and post-processing the database values. However, this hook has been called for all move operations for any table and was wrong in terms of the expected specific problem to be solved.

The hook gets reverted, since it's sufficient to resolve move placeholders if a record shall be created after an existing one.

The problem scenario back then was like this:

Page structure:
  • root
    • Y
      • X
      • M
    • A
Actions:
  • moving page "M" to page "A"
  • creating new page "N" after moved page "M" ("pid=-M")

The result was, that the new page "N" has been added as sub-page of "Y", the location of page "M" before it was moved. Thus, the move-placeholder just was not considered.

Actions #7

Updated by Oliver Hader almost 11 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #8

Updated by Riccardo De Contardi about 7 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF