Project

General

Profile

Actions

Task #56108

closed

Epic #55070: Workpackages

Epic #55065: WP: Overall System Performance (Backend and Frontend)

Cleanup \TYPO3\CMS\Recordlist\RecordList\DatabaseRecordList and friends

Added by Michiel Roos almost 11 years ago. Updated almost 9 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Code Cleanup
Target version:
Start date:
2014-02-19
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
5.3
Tags:
Complexity:
easy
Sprint Focus:

Description

Go over all the methods and clean them up where possible:
  • Checking values to be TRUE or FALSE instead of casting to boolean
  • Go over all loops to see if we can move repeatedly called methods on unchanging values outside of the loop
  • Go over htmlspecialchars usage
  • See if we can cache the fetching of the icon code

Files

AbstractRecordList.png (113 KB) AbstractRecordList.png Tymoteusz Motylewski, 2014-02-20 11:20
56108.patch (60.9 KB) 56108.patch Michiel Roos, 2014-02-24 23:32
Actions #1

Updated by Ingo Schmitt almost 11 years ago

  • Parent task set to #55070
Actions #2

Updated by Ingo Schmitt almost 11 years ago

  • Parent task changed from #55070 to #55065
Actions #3

Updated by Tymoteusz Motylewski almost 11 years ago

Attached class diagram (the only class missing on the diagram is the DatabaseRecordList from dbal).

Actions #4

Updated by Michiel Roos over 10 years ago

I'm abandoning this issue since there are only a handfull of micro optimisations that can be had here. And the word is that we are not doing any more of those so close before release in fear of breaking stuff.

Please find attached a patch with my work so far.

Some good came of this: https://review.typo3.org/#/c/27713/

Also the heaviest hogs in the extended db list are the preview icons in a page list. Those fetch the TSConfig for each page before rendering the appropriate page+eye icon. It would be nice to disable that icon using TSConfig. But that would be a feature. So maybe this issue will be revisited for a later version of TYPO3.

Actions #5

Updated by Anja Leichsenring almost 10 years ago

  • Sprint Focus set to On Location Sprint
Actions #6

Updated by Benni Mack over 9 years ago

  • Status changed from New to Closed

see comment by michiel

Actions #7

Updated by Anja Leichsenring almost 9 years ago

  • Sprint Focus deleted (On Location Sprint)
Actions

Also available in: Atom PDF