Task #56108

Epic #55070: Workpackages

Epic #55065: WP: Overall System Performance (Backend and Frontend)

Cleanup \TYPO3\CMS\Recordlist\RecordList\DatabaseRecordList and friends

Added by Michiel Roos over 5 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Code Cleanup
Target version:
Start date:
2014-02-19
Due date:
% Done:

0%

TYPO3 Version:
6.2
PHP Version:
5.3
Tags:
Complexity:
easy
Sprint Focus:

Description

Go over all the methods and clean them up where possible:
  • Checking values to be TRUE or FALSE instead of casting to boolean
  • Go over all loops to see if we can move repeatedly called methods on unchanging values outside of the loop
  • Go over htmlspecialchars usage
  • See if we can cache the fetching of the icon code

AbstractRecordList.png View (113 KB) Tymoteusz Motylewski, 2014-02-20 11:20

56108.patch View (60.9 KB) Michiel Roos, 2014-02-24 23:32

History

#1 Updated by Ingo Schmitt over 5 years ago

  • Parent task set to #55070

#2 Updated by Ingo Schmitt over 5 years ago

  • Parent task changed from #55070 to #55065

#3 Updated by Tymoteusz Motylewski over 5 years ago

Attached class diagram (the only class missing on the diagram is the DatabaseRecordList from dbal).

#4 Updated by Michiel Roos over 5 years ago

I'm abandoning this issue since there are only a handfull of micro optimisations that can be had here. And the word is that we are not doing any more of those so close before release in fear of breaking stuff.

Please find attached a patch with my work so far.

Some good came of this: https://review.typo3.org/#/c/27713/

Also the heaviest hogs in the extended db list are the preview icons in a page list. Those fetch the TSConfig for each page before rendering the appropriate page+eye icon. It would be nice to disable that icon using TSConfig. But that would be a feature. So maybe this issue will be revisited for a later version of TYPO3.

#5 Updated by Anja Leichsenring over 4 years ago

  • Sprint Focus set to On Location Sprint

#6 Updated by Benni Mack over 4 years ago

  • Status changed from New to Closed

see comment by michiel

#7 Updated by Anja Leichsenring almost 4 years ago

  • Sprint Focus deleted (On Location Sprint)

Also available in: Atom PDF