Bug #56253: Fatal Error at "Installing TYPO3 CMS" - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #56253

closed

Fatal Error at "Installing TYPO3 CMS"

Added by Andreas Fernandez over 10 years ago. Updated about 6 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Install Tool

Target version:

Start date:

2014-02-25

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

6.2

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

Hello TYPO3 team,

installing TYPO3 with an Oracle database (oci8) fails on certain points. After selecting oci8 and passing the credentials, the install wizard crashes with a fatal error:

PHP Fatal error: Cannot use object of type TYPO3\CMS\Core\Configuration\ConfigurationManager as array in typo3/sysext/install/Classes/Controller/Action/Step/DatabaseConnect.php on line 93

Please see the attached patch file to fix the bug.

Files

Download all files

DatabaseConnect.php.patch (1 KB) DatabaseConnect.php.patch		Andreas Fernandez, 2014-02-25 09:03
DatabaseConnect-2.diff (1.09 KB) DatabaseConnect-2.diff		Andreas Fernandez, 2014-02-25 14:07

Actions

Copy link

Updated by Andreas Fernandez over 10 years ago

Project changed from 1865 to TYPO3 Core

Actions

Copy link

Updated by Steffen Müller over 10 years ago

Is Regression set to No

I don't think the patch is correct.

The patch sets:

$config['_DEFAULT']['config']['driverOptions']['connectSID'] = $postValues['type'] === 'sid' ? TRUE : FALSE;

but $config is neither used below this line nor a reference.

Looking at the rest of the function, I guess something like the following is meant:

$config['_DEFAULT']['config']['driverOptions']['connectSID'] = $postValues['type'] === 'sid' ? TRUE : FALSE;
$configurationManager->setLocalConfigurationValueByPath('EXTCONF/dbal/handlerCfg', $config);

Disclaimer: This is just a guess by reading the code for the first time. I never used dbal or oracle.

Can you test and reproduce this on oracle?

Actions

Copy link

Updated by Steffen Müller over 10 years ago

Category set to Install Tool

Actions

Copy link

Updated by Andreas Fernandez over 10 years ago

File DatabaseConnect-2.diff DatabaseConnect-2.diff added

I tried your code and didn't notice any changes. So, I guess, it still works ;). I understand your point, but instead writing the new configuration back directly, I put it into $localConfigurationPathValuePairs. This array is written back into the configuration manager at the end of the method. Please see the attached diff.

Actions

Copy link

Updated by Markus Klein over 10 years ago

Instead of pushing patches here, you could push these to the review system. So we can keep track much better...

Actions

Copy link

Updated by Andreas Fernandez over 10 years ago

Link to code review: https://review.typo3.org/#/c/27846/

Actions

Copy link

Updated by Gerrit Code Review over 10 years ago

Status changed from New to Under Review

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27846

Actions

Copy link

Updated by Gerrit Code Review over 10 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27846

Actions

Copy link

Updated by Gerrit Code Review over 10 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27846

Actions

Copy link

#10

Updated by Gerrit Code Review over 10 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27846

Actions

Copy link

#11

Updated by Gerrit Code Review over 10 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27846

Actions

Copy link

#12