TYPO3 Core

I don't think the patch is correct.

The patch sets:

$config['_DEFAULT']['config']['driverOptions']['connectSID'] = $postValues['type'] === 'sid' ? TRUE : FALSE;

but $config is neither used below this line nor a reference.

Looking at the rest of the function, I guess something like the following is meant:

$config['_DEFAULT']['config']['driverOptions']['connectSID'] = $postValues['type'] === 'sid' ? TRUE : FALSE;
$configurationManager->setLocalConfigurationValueByPath('EXTCONF/dbal/handlerCfg', $config);

Disclaimer: This is just a guess by reading the code for the first time. I never used dbal or oracle.

Can you test and reproduce this on oracle?

I tried your code and didn't notice any changes. So, I guess, it still works ;). I understand your point, but instead writing the new configuration back directly, I put it into $localConfigurationPathValuePairs. This array is written back into the configuration manager at the end of the method. Please see the attached diff.

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27846

Applied in changeset 4da4dba52009760005095a5013245d5d169ce9a5.