Bug #56786

Index on sys_file_processedfile is too large

Added by Ernesto Baschny over 5 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Should have
Category:
File Abstraction Layer (FAL)
Target version:
Start date:
2014-03-11
Due date:
% Done:

100%

TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
easy
Is Regression:
No
Sprint Focus:

Description

Since #54234 a SQL error in the Upgrade Wizard / Database Compare is left open:

ALTER TABLE sys_file_processedfile ADD KEY identifier (storage,identifier); 
Specified key was too long; max key length is 1000 bytes

"identifier" is varchar(512) but on utf8 charset every character needs 3 bytes of space. So the index is "too large" (for MyISAM).

Solution would be to limit the key to the first 332 chars.


Related issues

Related to TYPO3 Core - Task #54234: Prevent creation of FileObjects for ProcessedFiles Closed 2013-12-06
Related to TYPO3 Core - Bug #57805: SQL-ERROR: Specified key was too long Closed 2014-04-10
Duplicated by TYPO3 Core - Bug #57002: SQL-Errors while Upgrading the database with Upgrade Wizard Closed 2014-03-17

Associated revisions

Revision aa1fb872 (diff)
Added by Ernesto Baschny over 5 years ago

[BUGFIX] Index on sys_file_processedfile is too large

Resolves: #56786
Related: #54234
Releases: 6.2
Change-Id: I9c91f3e989e65df559542135d0b84025dacbbaf2
Reviewed-on: https://review.typo3.org/28272
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Marcin Sągol
Tested-by: Marcin Sągol
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

Revision 7d80f335 (diff)
Added by Ernesto Baschny over 5 years ago

[BUGFIX] Index on sys_file_processedfile is still too large

On some systems even "332" characters is too large. To also cope with
potential utf8mb4 setups (1 char = 4 bytes), and staying under 1000 byte
limit, we reduce the amount of characters in the index to 249.

Resolves: #56786
Related: #54234
Releases: 6.2
Change-Id: I79452224f37ec2b6ca5b3a35044144eed787df67
Reviewed-on: https://review.typo3.org/28429
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny

History

#1 Updated by Gerrit Code Review over 5 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28272

#2 Updated by Gerrit Code Review over 5 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28272

#3 Updated by Ernesto Baschny over 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#4 Updated by Gerrit Code Review over 5 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28429

#5 Updated by Ernesto Baschny over 5 years ago

  • Status changed from Under Review to Resolved

#6 Updated by Riccardo De Contardi over 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF