Task #56792
closedEnhance assertion of error log entries
0%
Description
During the action tests it might happen, that errors occur. To assert expected or unexpected error log entries in the sys_log table, this functionality shall be added to the functional testing framework.
The current implementation just checks the amount of entries, which should be "0" in most cases - which is a bit weak to be considered as complete assertion.
Peter Niederlag shared some ideas during the review process which shall be part of a separate follow-up change.
// set by freezeErrorId() and used by assertErrorLogCreated()
protected $frozenErrorId = NULL;
// freeze ErrorLog
protected freezeErrorLog() { if $this->latestErrorId !== NULL { raise Exception('errorLog already frozen, use assertErrorLogCreated() before freezing again') }
$this->latestErrorId = sqlfetchIdofLatestErrorbyTimestamp();
}
assertErrorLogsCreated($expectedCount = 1, $detailPatterns = array() ) {
// check/warning on frozenErrorId (should be called prior to this assertion)
// check if there are $expectedCount new errorLogs (id > this->frozenErrorId)
// optionally check with regex
// finally reset frozenErrorId
$this->frozenErrorId = NULL;
}
(find discussion here https://review.typo3.org/#/c/27886/2/typo3/sysext/core/Tests/Functional/DataHandling/AbstractDataHandlerActionTestCase.php,unified)
Updated by Anja Leichsenring almost 10 years ago
- Sprint Focus set to On Location Sprint
Updated by Anja Leichsenring over 9 years ago
- Sprint Focus changed from On Location Sprint to Remote Sprint
Updated by Oliver Hader about 9 years ago
- Target version changed from 7.5 to 8 LTS
- Complexity set to medium
Updated by Benni Mack over 7 years ago
- Target version changed from 8 LTS to Candidate for patchlevel
Updated by Susanne Moog about 7 years ago
- Status changed from New to Accepted
- Tags set to testing-framework
Updated by Susanne Moog about 7 years ago
- Status changed from Accepted to Closed
We will track this issue in the testing framework project on github, see https://github.com/TYPO3/testing-framework/issues/38