Task #57173

Epic #55070: Workpackages

Epic #55065: WP: Overall System Performance (Backend and Frontend)

Epic #55656: Optimize overall Extbase performance

Story #55168: Optimize Extbase generic persistence

Task #55167: Extbase: avoid parseQuery() / buildQuery() to be called multiple times

Use of cf_extbase_typo3dbbackend_queries results in fatal

Added by Xavier Perseguers over 5 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Must have
Category:
Extbase
Target version:
Start date:
2014-03-22
Due date:
% Done:

100%

TYPO3 Version:
6.2
PHP Version:
5.4
Tags:
Complexity:
Sprint Focus:

Description

After upgrading to RC1 and creating cache table cf_extbase_typo3dbbackend_queries (and _tags), queries on fe_users now fatal.

My query on fe_users (findAll or findByUsergroup, does not matter) fails while mapping fe_users to FrontendUser objects because the WHERE clause reads:

fe_groups.uid = '6','8' AND fe_groups.deleted=0 AND fe_groups.hidden=0

see the "=" with two values

This happens as soon as it tries to map a fe_users with 2 fe_groups associated (6 and 8)

Associated revisions

Revision ed50510a (diff)
Added by Xavier Perseguers over 5 years ago

[BUGFIX] preparseQuery wrongly computes cache hash of a query

preparseQuery only takes query's parameters to compute its hash but
not the operators used. As such, those two queries result into the
same cache hash:

SELECT * FROM fe_groups WHERE uid = :uid

SELECT * FROM fe_groups WHERE uid IN (:uid)

Fixes: #57173
Releases: 6.2
Change-Id: I6a65ba0be81da73f55c2e6a73f508728567064c3
Reviewed-on: https://review.typo3.org/28656
Reviewed-by: Felix Oertel
Tested-by: Felix Oertel
Reviewed-by: Markus Klein
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe

History

#1 Updated by Xavier Perseguers over 5 years ago

  • Is Regression changed from No to Yes

#2 Updated by Xavier Perseguers over 5 years ago

  • Category set to Extbase

#3 Updated by Ernesto Baschny over 5 years ago

  • Parent task set to #55167

#4 Updated by Xavier Perseguers over 5 years ago

  • Status changed from New to Accepted
  • Assignee set to Xavier Perseguers

#5 Updated by Gerrit Code Review over 5 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28656

#6 Updated by Gerrit Code Review over 5 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28656

#7 Updated by Gerrit Code Review over 5 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28656

#8 Updated by Gerrit Code Review over 5 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28656

#9 Updated by Gerrit Code Review over 5 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28656

#10 Updated by Gerrit Code Review over 5 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28656

#11 Updated by Xavier Perseguers over 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#12 Updated by Riccardo De Contardi almost 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF