Bug #57488
closedpage record overlays: media field not translatable
Added by Alexander Dick almost 11 years ago. Updated over 6 years ago.
100%
Description
Reproduce:
1) add some images to the media field of a page
2) translate the page
3) no localizable images from the original record show up!
Files
media_615.jpg (6.84 KB) media_615.jpg | View of the localized page in 6.1.5 | Thomas Fersterer, 2014-04-10 13:25 | |
media_62_de.jpg (17.5 KB) media_62_de.jpg | Resources in 6.2 (default language) | Thomas Fersterer, 2014-04-10 13:25 | |
media_62_en.jpg (16.3 KB) media_62_en.jpg | Resources in 6.2 (localized version) | Thomas Fersterer, 2014-04-10 13:25 | |
forge_57488.png (19.3 KB) forge_57488.png | Oliver Hader, 2014-04-28 18:04 | ||
page_record_overlay_editmode.png (22.1 KB) page_record_overlay_editmode.png | Alexander Dick, 2014-04-28 19:13 | ||
forge_57488_wip.png (46.3 KB) forge_57488_wip.png | Oliver Hader, 2014-04-28 22:46 |
Updated by Stefan Neufeind almost 11 years ago
Can you maybe say if it worked in 6.0/6.1 or so?
Updated by Thomas Fersterer almost 11 years ago
- File media_615.jpg media_615.jpg added
- File media_62_de.jpg media_62_de.jpg added
- File media_62_en.jpg media_62_en.jpg added
I can reproduce it in 6.2, in 6.1.5 it works fine.
Updated by Oliver Hader over 10 years ago
- Category changed from Localization to File Abstraction Layer (FAL)
- Status changed from New to Accepted
- Priority changed from Must have to Should have
I can confirm this misbehaviour...
Updated by Oliver Hader over 10 years ago
- Complexity set to medium
I guess you're using the Page Module's "make new translation of this page", right? (see screenshot forge_57488.png)
The problem here is, that only the dokType and sys_language_uid is forwared to the edit form...
Updated by Oliver Hader over 10 years ago
- File forge_57488.png forge_57488.png added
Updated by Alexander Dick over 10 years ago
Exactly! I am using "make new translation of this page". When I'm editing an existing translation it looks like on the attached screenshot.
Updated by Oliver Hader over 10 years ago
- Assignee set to Oliver Hader
Alright, I'm investigating... I could narrow down the issue to DataPreprocessor, will check further...
The "media" field is empty if delivered from DataPreprocessor in the localization "context"...
Updated by Oliver Hader over 10 years ago
Oliver Hader wrote:
Alright, I'm investigating... I could narrow down the issue to DataPreprocessor, will check further...
The "media" field is empty if delivered from DataPreprocessor in the localization "context"...
Ok, easier than that... the configuration in #52816 just was set from TRUE to FALSE 'showPossibleLocalizationRecords' => FALSE,
'showRemovedLocalizationRecords' => FALSE,
'showSynchronizationLink' => FALSE,
Updated by Gerrit Code Review over 10 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/29719
Updated by Oliver Hader over 10 years ago
I just could come up with a work-in-progress solution (maybe it turns out to be fine in the end).
Thus, the IRRE localization behaviour has been re-added for pages_language_overlay.media field.
If the record is new in the edit view, the "localize all records" is not shown since the new overlay record does not have a proper uid value, yet.
This is the major difference if compared to the bahaviour with tt_content elements - those are copied/localized directly and thus the file reference can be copied along as well ("localizeChildrenAtParentLocalization" in the TCA behaviour section).
Please test the linked patch from review.typo3.org (even it is work-in-progress) and gimme some feedback. Thanks!
Updated by Oliver Hader over 10 years ago
- File forge_57488_wip.png forge_57488_wip.png added
Updated by Gerrit Code Review over 10 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/29719
Updated by Gerrit Code Review over 10 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/29719
Updated by Alexander Dick over 10 years ago
Is there a language overlay/fallback for those fields?
config.sys_language_mode = content_fallback; 1,0
config.sys_language_overlay = 1
With these settings I would expect the records of the default language to show up when they are not translated in the current language. Currently no records show up.
As soon as I localize them, they show up.
Updated by Oliver Hader over 10 years ago
Thanks for testing and your feedback on this. That's a good catch!
If a localized page is used, the reference pointer used "pages_language_overlay" to lookup accordant references in table "sys_file_references", see
https://git.typo3.org/Packages/TYPO3.CMS.git/blob/HEAD:/typo3/sysext/frontend/Classes/ContentObject/FilesContentObject.php#l94
- fetch references for pages_language_overlay for the "_LOCALIZED_UID" value
- if there are no references in the overlay, fallback to references pointing pages and the "uid" value
Since this is still hardcoded, a similar method like in PageRepository::shouldFieldBeOverlaid() is required for this case (e.g. "l10n_mode" = "exclude" or "mergeIfNotBlank").
There are some more things to be done concerning overlays and fallbacks, thus I'd opt to create a separate FAL issue here.
Updated by Gerrit Code Review over 10 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/29719
Updated by Oliver Hader over 10 years ago
The overlay behavior part can be found in a separate issue #58352
Thus, if you'd like to test the backend behavior and frontend output you should cherry-pick those two patches.
Updated by Oliver Hader over 10 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset a13a45454c6c7285e00c0ad11f3a6025ddd4bca0.
Updated by Herbert Sojnik over 9 years ago
Is this feature not included in TYPO3 6.2.14?
I checked the code of typo3/sysext/frontend/Configuration/TCA/pages_language_overlay.php and here are the modifications beginning in line 158 missing.
Thanks for info.
Updated by Markus Timtner over 9 years ago
I can confirm this - the changes in pages_lanmgauge_overlay.php are at least missing in the source for 6.2.10, too.
Updated by Julian Stock over 8 years ago
Any news on this? It's still not in 6.2.26 :(
Updated by Fronzes Philippe about 8 years ago
Hi,
Still got this problem on a 7.6.11.
Updated by Oliver Hader almost 8 years ago
There was a follow-up issue in #58476