Task #59535
closedRe-work/simplify copyright header in PHP files
100%
Description
The copyright/license header in files (PHP files, maybe others such as JavaScript, etc.) of the TYPO3 core show the year range 1998-2013. Initiated as issue #55748, discussed in several conversations (e.g. [1], [2] and [3]) and confirmed by the License Team (see issue #56776), we agreed on re-working the copyright header and drop the year figure as part of a simplification.
This patch updates 2000+ PHP files and replaces the current header with the new one.
[1] http://lists.typo3.org/pipermail/typo3-team-core/2014-February/055257.html
[2] http://lists.typo3.org/pipermail/typo3-team-core/2014-May/055784.html
[3] http://lists.typo3.org/pipermail/typo3-team-core/2014-June/055904.html
Files
Updated by Gerrit Code Review over 10 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30709
Updated by Michael Schams over 10 years ago
- File issue59535-1.png issue59535-1.png added
Updated by Gerrit Code Review over 10 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30709
Updated by Alexander Opitz over 10 years ago
In #56776 Olivier wrote:
"GPL2 or any later version in the license header"
But the patch introduces LGPL v3 and I think this isn't intended.
Updated by Michael Schams over 10 years ago
You are right - that's not correct. It should read:
/** * This file is part of the TYPO3 CMS project. * * It is free software; you can redistribute it and/or modify it under * the terms of the GNU General Public License, either version 2 * of the License, or any later version. * * For the full copyright and license information, please read the * LICENSE.txt file that was distributed with this source code. * * The TYPO3 project - inspiring people to share! */
I will create a new patch set.
Updated by Gerrit Code Review over 10 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30709
Updated by Gerrit Code Review over 10 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30709
Updated by Michael Schams over 10 years ago
Discussed with Markus Klein:
It would be legitimate to split this issue into several sub-tickets (and make this ticket the "parent" ticket) and let each sub-ticket handle a part of
the whole list, e.g. 100 or 200 files each time in order to prevent jenkins to fail. We currently try to cover 3000+ files in total here.
I could take care of that but nevertheless, I need someone who reviews the files and merges the change in a timely manner.
Updated by Gerrit Code Review over 10 years ago
- Estimated time set to 0.00 h
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30709
Updated by Markus Klein over 10 years ago
- Category set to Code Cleanup
- Assignee set to Michael Schams
- Target version set to next-patchlevel
- Estimated time set to 0.00 h
- Complexity set to easy
Please add a 10th part for the JS files. Thank you
Updated by Gerrit Code Review over 10 years ago
Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31047
Updated by Markus Klein over 10 years ago
- Status changed from Under Review to Resolved
- Estimated time set to 0.00 h
Applied in changeset 8f938a17bdd1766e656574eaea6aa0dbfa2e386a.