TYPO3 Core

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31081

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31081

The patch does'nt work for me.
I need showForgotPassword and showForgotPasswordLink in TS again.

@Karsten Hachmeister: Please post feedback to the patches right into our review system. Thank you.

Hello,

sorry for reopening this again, but in my opinion the current bug fix solves the problem of the bug reporter, but creates a regression and a breaking change in behaviour. If I'm wrong, please correct me :)

As I still have a problem with this feature in TYPO3 CMS 6.2.4, I did some research. What I mean:
As far as I know there are two settings for this feature in felogin, even in TYPO3 CMS 4.5 and all later version including 6.1:
- "showForgotPasswordLink" was the option which could be set by typoscript. It is described with this key in the documentation and there is also a "blind" entry in the default typoscript the extension includes
- "showForgotPassword" is the option which can be set in the flexform

Until 6.1 both options work, as when checking for the "forgot" value, none of these options is checked. They are only checked when the login form is created and at least one of them has to be set.

With 6.2.0 there was a breaking change then:
The forgot link was created when any of the values is set, but when checking in the main method, what has to be displayed, only "showForgotPassword" is checked - and HAS to be true. So tzhis works only when the option in the floxform is set. Setting (only) in typoscript does not work.

Now we have this issue and the patchset. It changes the behaviour completely:
1. When checking for displaying the link (line 587), only the typoscript option "showForgotPasswordLink" is checked any more.
2. When chacking what to display in method "main", also only this option is checked. At least the same options are used, that's true. But indeed it changes behaviour of the exension completely again. Now the flexform setting is completely ignored and only typoscript used.

The resolution is quite simple:
In both checks (587: display link or not; 156: what to display) both values have to be checked. If one of them is true, then the link and the form should be displayed.
This way the felogin alsao keeps the same behaviour as it has in all former versions beginning with 4.5 (4.3?).

Regards,
André