Project

General

Profile

Actions
Copy link

Bug #60213

closed

pageRenderer->addJsFooterFile doesn't work as expected

Added by Bernhard Kraft almost 10 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Backend API
Target version:
-
Start date:
2014-07-09
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
5.3
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

When using "addJsFooterFile" to add JS files to a backend module this doesn't work as expected.
The reason for this is located in backend/Classes/Template/DocumentTemplate.php @ line 910 and 914
(https://git.typo3.org/Packages/TYPO3.CMS.git/blob/HEAD:/typo3/sysext/backend/Classes/Template/DocumentTemplate.php#l910)

The pageRenderer method "render" is called twice. Once for rendering the header and a second time for rendering the footer. But inside the render method the internal "jsFiles" and all other variables get reset:
https://git.typo3.org/Packages/TYPO3.CMS.git/blob/HEAD:/typo3/sysext/core/Classes/Page/PageRenderer.php#l1943

It is stated, that the pageRenderer needs a full reset after each rendering - but it is not stated why this full reset is needed.

I created a patch which disables the reset via an argument to ->render method. This did not show any side effects for a few short tests.

Files

patch_60213.diff (2.24 KB) patch_60213.diff Bernhard Kraft, 2014-07-09 18:47

Related issues 3 (0 open — 3 closed)

Related to TYPO3 Core - Bug #57920: PageRenderer do not unset() class membersClosed2014-04-15

Actions
Related to TYPO3 Core - Bug #57294: pageRenderer was resetted after render callClosed2014-03-25

Actions
Related to TYPO3 Core - Task #58581: Clarify reset in page renderer commentClosed2014-05-06

Actions
Actions
Copy link

Also available in: Atom PDF