Bug #60272
closedSkip cache hash for URIs to non-cacheable actions
100%
Description
When URIs are built pointing to non-cacheable actions, currently a cache hash is always included.
This should be skipped if the current request is already uncached.
Updated by Gerrit Code Review over 10 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31594
Updated by Gerrit Code Review over 10 years ago
Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31595
Updated by Gerrit Code Review over 10 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31594
Updated by Alexander Opitz about 10 years ago
- Project changed from 534 to TYPO3 Core
- Category changed from Extbase: MVC to Extbase
- TYPO3 Version set to 6.2
- Is Regression set to No
Updated by Gerrit Code Review about 10 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31594
Updated by Gerrit Code Review about 10 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31594
Updated by Helmut Hummel about 10 years ago
Mathias Brodala wrote:
When URIs are built pointing to non-cacheable actions, currently a cache hash is always included.
This should be skipped if the current request is already uncached.
This is wrong unfortunately and would introduce a regression.
If a plugin is on a page which has a cached action as default, the page will be cached with the rendered default action.
If the rendered HTML contains a link to an uncached action on the same page, this link will not work any more unless we include the cHash to create a new cache entry for the page which renders a placeholder for the plugin which is then executed on each request (USER_INT).
Updated by Mathias Brodala about 10 years ago
Helmut Hummel wrote:
If a plugin is on a page which has a cached action as default, the page will be cached with the rendered default action.
If the rendered HTML contains a link to an uncached action on the same page, this link will not work any more unless we include the cHash to create a new cache entry for the page which renders a placeholder for the plugin which is then executed on each request (USER_INT).
I'm not sure if I understand you or you understand me. ;-) This issue is about links from an uncached action (=request) to an uncached action. How would this affect unrelated cached actions?
Updated by Helmut Hummel about 10 years ago
Mathias Brodala wrote:
This issue is about links from an uncached action (=request) to an uncached action. How would this affect unrelated cached actions?
Ah, I missed that part, sorry. If it is only about disabling the cHash if the current request is uncached and pointing to an uncached action, this would technically be OK. (It would break my typoscript_rendering Extension, but that should not be a blocker for such a change ;) )
Updated by Gerrit Code Review about 10 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31594
Updated by Gerrit Code Review about 10 years ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31594
Updated by Gerrit Code Review about 10 years ago
Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31594
Updated by Gerrit Code Review almost 10 years ago
Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31594
Updated by Gerrit Code Review almost 10 years ago
Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31594
Updated by Gerrit Code Review almost 10 years ago
Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31594
Updated by Gerrit Code Review almost 10 years ago
Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31594
Updated by Gerrit Code Review almost 10 years ago
Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31594
Updated by Mathias Brodala almost 10 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 3ab6f2a08283041d52a05db3e26817c66024da88.