Bug #60272

Skip cache hash for URIs to non-cacheable actions

Added by Mathias Brodala over 5 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Category:
Extbase
Target version:
Start date:
2014-07-11
Due date:
% Done:

100%

TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
easy
Is Regression:
No
Sprint Focus:

Description

When URIs are built pointing to non-cacheable actions, currently a cache hash is always included.

This should be skipped if the current request is already uncached.


Related issues

Related to TYPO3 Core - Bug #65629: Regression in page module in workspace (Fatal error: Call to a member function isCached() on a non-object i) Closed 2015-03-09
Related to TYPO3 Core - Bug #67097: cHash removed even if explicitly enabled Closed 2015-05-22

Associated revisions

Revision 3ab6f2a0 (diff)
Added by Mathias Brodala over 4 years ago

[!!!][BUGFIX] Skip cache hash for URIs to non-cacheable actions

When building an URI for a non-cacheable action, while the current
request also is uncached, we can skip the cache hash for the target URI
to avoid unnecessary page cache entries.

Since this is a change in behavior during link generation, which other
code may rely upon, this is marked as breaking change.

Resolves: #60272
Releases: master
Change-Id: I448c33d23b790de1064eff95d0a940878b0299ac
Reviewed-on: http://review.typo3.org/31594
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>
Reviewed-by: Stefan Neufeind <>
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>
Reviewed-by: Helmut Hummel <>
Tested-by: Helmut Hummel <>

History

#1 Updated by Gerrit Code Review over 5 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31594

#2 Updated by Gerrit Code Review over 5 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31595

#3 Updated by Gerrit Code Review over 5 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31594

#4 Updated by Alexander Opitz about 5 years ago

  • Project changed from Extbase MVC Framework to TYPO3 Core
  • Category changed from Extbase: MVC to Extbase
  • TYPO3 Version set to 6.2
  • Is Regression set to No

#5 Updated by Gerrit Code Review about 5 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31594

#6 Updated by Gerrit Code Review about 5 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31594

#7 Updated by Helmut Hummel about 5 years ago

Mathias Brodala wrote:

When URIs are built pointing to non-cacheable actions, currently a cache hash is always included.

This should be skipped if the current request is already uncached.

This is wrong unfortunately and would introduce a regression.

If a plugin is on a page which has a cached action as default, the page will be cached with the rendered default action.
If the rendered HTML contains a link to an uncached action on the same page, this link will not work any more unless we include the cHash to create a new cache entry for the page which renders a placeholder for the plugin which is then executed on each request (USER_INT).

#8 Updated by Mathias Brodala about 5 years ago

Helmut Hummel wrote:

If a plugin is on a page which has a cached action as default, the page will be cached with the rendered default action.
If the rendered HTML contains a link to an uncached action on the same page, this link will not work any more unless we include the cHash to create a new cache entry for the page which renders a placeholder for the plugin which is then executed on each request (USER_INT).

I'm not sure if I understand you or you understand me. ;-) This issue is about links from an uncached action (=request) to an uncached action. How would this affect unrelated cached actions?

#9 Updated by Helmut Hummel about 5 years ago

Mathias Brodala wrote:

This issue is about links from an uncached action (=request) to an uncached action. How would this affect unrelated cached actions?

Ah, I missed that part, sorry. If it is only about disabling the cHash if the current request is uncached and pointing to an uncached action, this would technically be OK. (It would break my typoscript_rendering Extension, but that should not be a blocker for such a change ;) )

#10 Updated by Gerrit Code Review about 5 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31594

#11 Updated by Gerrit Code Review about 5 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31594

#12 Updated by Gerrit Code Review about 5 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31594

#13 Updated by Gerrit Code Review almost 5 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31594

#14 Updated by Gerrit Code Review almost 5 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31594

#15 Updated by Gerrit Code Review almost 5 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31594

#16 Updated by Gerrit Code Review almost 5 years ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31594

#17 Updated by Gerrit Code Review almost 5 years ago

Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31594

#18 Updated by Mathias Brodala over 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#19 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF