Project

General

Profile

Actions

Bug #60272

closed

Skip cache hash for URIs to non-cacheable actions

Added by Mathias Brodala over 9 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Category:
Extbase
Target version:
Start date:
2014-07-11
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
easy
Is Regression:
No
Sprint Focus:

Description

When URIs are built pointing to non-cacheable actions, currently a cache hash is always included.

This should be skipped if the current request is already uncached.


Related issues 2 (0 open2 closed)

Related to TYPO3 Core - Bug #65629: Regression in page module in workspace (Fatal error: Call to a member function isCached() on a non-object i)Closed2015-03-09

Actions
Related to TYPO3 Core - Bug #67097: cHash removed even if explicitly enabledClosedMathias Brodala2015-05-22

Actions
Actions #1

Updated by Gerrit Code Review over 9 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31594

Actions #2

Updated by Gerrit Code Review over 9 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31595

Actions #3

Updated by Gerrit Code Review over 9 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31594

Actions #4

Updated by Alexander Opitz over 9 years ago

  • Project changed from 534 to TYPO3 Core
  • Category changed from Extbase: MVC to Extbase
  • TYPO3 Version set to 6.2
  • Is Regression set to No
Actions #5

Updated by Gerrit Code Review over 9 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31594

Actions #6

Updated by Gerrit Code Review over 9 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31594

Actions #7

Updated by Helmut Hummel over 9 years ago

Mathias Brodala wrote:

When URIs are built pointing to non-cacheable actions, currently a cache hash is always included.

This should be skipped if the current request is already uncached.

This is wrong unfortunately and would introduce a regression.

If a plugin is on a page which has a cached action as default, the page will be cached with the rendered default action.
If the rendered HTML contains a link to an uncached action on the same page, this link will not work any more unless we include the cHash to create a new cache entry for the page which renders a placeholder for the plugin which is then executed on each request (USER_INT).

Actions #8

Updated by Mathias Brodala over 9 years ago

Helmut Hummel wrote:

If a plugin is on a page which has a cached action as default, the page will be cached with the rendered default action.
If the rendered HTML contains a link to an uncached action on the same page, this link will not work any more unless we include the cHash to create a new cache entry for the page which renders a placeholder for the plugin which is then executed on each request (USER_INT).

I'm not sure if I understand you or you understand me. ;-) This issue is about links from an uncached action (=request) to an uncached action. How would this affect unrelated cached actions?

Actions #9

Updated by Helmut Hummel over 9 years ago

Mathias Brodala wrote:

This issue is about links from an uncached action (=request) to an uncached action. How would this affect unrelated cached actions?

Ah, I missed that part, sorry. If it is only about disabling the cHash if the current request is uncached and pointing to an uncached action, this would technically be OK. (It would break my typoscript_rendering Extension, but that should not be a blocker for such a change ;) )

Actions #10

Updated by Gerrit Code Review over 9 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31594

Actions #11

Updated by Gerrit Code Review over 9 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31594

Actions #12

Updated by Gerrit Code Review over 9 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31594

Actions #13

Updated by Gerrit Code Review over 9 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31594

Actions #14

Updated by Gerrit Code Review over 9 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31594

Actions #15

Updated by Gerrit Code Review over 9 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31594

Actions #16

Updated by Gerrit Code Review over 9 years ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31594

Actions #17

Updated by Gerrit Code Review over 9 years ago

Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31594

Actions #18

Updated by Mathias Brodala about 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #19

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF