Bug #67097

cHash removed even if explicitly enabled

Added by Mathias Brodala over 4 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Must have
Category:
Extbase
Target version:
Start date:
2015-05-22
Due date:
% Done:

100%

TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
Yes
Sprint Focus:
Stabilization Sprint

Description

With #60272 the UriBuilder learned to disable the cHash if the current request and target action are uncached.

This however, can lead to issues if the cHash was explicitely enabled via useCacheHash, thus this logic should not be applied if useCacheHash was explicitely set.


Related issues

Related to TYPO3 Core - Bug #60272: Skip cache hash for URIs to non-cacheable actions Closed 2014-07-11

Associated revisions

Revision d9ebc5c0 (diff)
Added by Helmut Hummel about 4 years ago

Revert "[!!!][BUGFIX] Skip cache hash for URIs to non-cacheable actions"

This reverts commit 3ab6f2a08283041d52a05db3e26817c66024da88.

This change caused trouble, as it was not possible any more to explicitly enable
cHash usage. In situations where some arguments are required for a cHash, this
will lead to a broken page (404) when the cHash is skipped.

As the possible gain of not having the cHash is low but the possible impact is high
and a potential fix is breaking or at least fragile as well, this feature is reverted again.

Resolves: #67097
Reverts: #60272
Releases: master
Change-Id: Ia14947f8eb6b6125b0402ae7e046c78a1597aeae
Reviewed-on: http://review.typo3.org/43688
Reviewed-by: Wouter Wolters <>
Tested-by: Wouter Wolters <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>

History

#1 Updated by Gerrit Code Review over 4 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39657

#2 Updated by Gerrit Code Review over 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39657

#3 Updated by Gerrit Code Review over 4 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39657

#4 Updated by Gerrit Code Review over 4 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39657

#5 Updated by Gerrit Code Review over 4 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39657

#6 Updated by Gerrit Code Review over 4 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39657

#7 Updated by Gerrit Code Review over 4 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39657

#8 Updated by Gerrit Code Review over 4 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39657

#9 Updated by Gerrit Code Review over 4 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39657

#10 Updated by Susanne Moog over 4 years ago

  • Target version changed from 7.4 (Backend) to 7.5

#11 Updated by Benni Mack about 4 years ago

  • Target version deleted (7.5)

#12 Updated by Helmut Hummel about 4 years ago

  • Sprint Focus set to Stabilization Sprint

#13 Updated by Helmut Hummel about 4 years ago

  • Target version set to 7 LTS

#14 Updated by Gerrit Code Review about 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43688

#15 Updated by Gerrit Code Review about 4 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43688

#16 Updated by Helmut Hummel about 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#17 Updated by Riccardo De Contardi about 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF