Project

General

Profile

Actions

Bug #60437

closed

Senders name with special chars does not work in default form

Added by Ayke Halder almost 10 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
-
Target version:
-
Start date:
2014-07-21
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
easy
Is Regression:
No
Sprint Focus:

Description

Special chars like Umlaute ÄÖÜ in the senders name of a form are not displayed correctly in all mail clients. And the default hostname is always added, if special chars are used.

From line in test email:

From: "Test =?utf-8?Q?=C3=84=C3=96=C3=9C_=C3=9F_=C3=A4=C3=B6=C3=BC=22?=  <Test123@example.org>"@hostname.hoster.org

Shows in Thunderbird like:
"Test ÄÖÜ ß äöü" "@hostname.hoster.org

Test ÄÖÜ ß äöü <Test123@example.org>@hostname.hoster.org

To work it should be:

From: Test =?utf-8?Q?=C3=84=C3=96=C3=9C_=C3=9F_=C3=A4=C3=B6=C3=BC?= <Test123@example.org>

Shows in Thunderbird like:
Test ÄÖÜ ß äöü

Test ÄÖÜ ß äöü <Test123@example.org>

The problem is the quotation in
typo3_src-6.2.1/typo3/sysext/form/Classes/PostProcess/MailPostProcessor.php

Lines 141 - 143:

        if (preg_match('/\\s|,/', $fromName) >= 1) {
            $fromName = '"' . $fromName . '"';
        }

Blank chars in the senders name should be handled by Swift Mailer.
I think this lines can be removed.


Files

form_test_sender-name_with_special-chars-z.t3d (3.38 KB) form_test_sender-name_with_special-chars-z.t3d Simple website with form Ayke Halder, 2014-07-24 01:31

Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #60227: Update Swiftmaler to latest version to offer signed + encrypted emailsClosed2014-07-10

Actions
Actions #1

Updated by Markus Klein almost 10 years ago

Did you check with the swift mailer source whether it escapes the fromName correctly and does add the quotes?

Actions #2

Updated by Ayke Halder almost 10 years ago

No it doesn't add quotes, but escapes it correctly. Is there any need for quotes?

Example on http://swiftmailer.org/docs/messages.html

// Set the From address with an associative array
  ->setFrom(array('john@doe.com' => 'John Doe'))

No quotes here

Sending mails with Thunderbird does not set any quotes either.

http://www.ietf.org/rfc/rfc1342.txt
See pages 5 & 6 for examples, e.g.

CC: =?ISO-8859-1?Q?Andr=E9_?= Pirard <PIRARD@vm1.ulg.ac.be>

This is the behaviour if lines 141 - 143 are removed:
Words containing special chars are encoded separately and no quotes are added at all.

Actions #3

Updated by Stefan Neufeind almost 10 years ago

Do you have a chance to check if the updated swiftmailer from master (5.2.1) maybe makes a difference? Thats not in the 6.2-tree though, just master (6.3 or so).
https://review.typo3.org/31572 - forge-issue #60227.

Actions #4

Updated by Ayke Halder almost 10 years ago

Checked it on TYPO3 6.3 master and no difference.
In the file is a simple example website to reproduce the problem.

Actions #5

Updated by Gerrit Code Review over 9 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33499

Actions #6

Updated by Gerrit Code Review over 9 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33603

Actions #7

Updated by Markus Klein over 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #8

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF