Feature #61993

Exclude Page CSS from Concatenation

Added by Thomas Christiansen about 5 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Frontend
Target version:
-
Start date:
2014-10-01
Due date:
% Done:

100%

PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Hey Folks,
I discovered that Page CSS from css_styled_content like .csc-space-before-20 { margin-top: 20px !important; } and so on is always concatenated with the other stylesheets which are included in the page.
This leads to nearly each Page has an individual CSS-File even if there is only one line different.
I dont think this is really perfomant because the browser has to download the whole file on each page.

Excluding the Page CSS from concatenation solves this issue because the majority of css is in one file which can be cached by the browser. If there is any Page Css it is in a tiny secondary file.

I know there is the setting config.inlineStyle2TempFile which could solve this issue too, but having all the inline styles in the header of the page is neither necessary nor very pretty.

So i came up with a new Setting config.concatenateCss.excludePageCss = 1 which solves this issue for me.

I push my solution to the review server.

Thanks, Thomas

Associated revisions

Revision b62a10ab (diff)
Added by Susanne Moog over 4 years ago

[FEATURE] Exclude Page CSS from Concatenation

CSS added via _CSS_PAGE_STYLE is no longer included in
the concatenated css files. It can be written in an external
file or as inline block (depending on inlineStyle2TempFile).

Additionally the config.compressCss setting is now taken into
account.

Resolves: #61993
Releases: master

Change-Id: I0c9cc6ababbd5695b0dab26e7d421f28b5f73bb0
Reviewed-on: http://review.typo3.org/33098
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>
Reviewed-by: Susanne Moog <>
Tested-by: Susanne Moog <>

History

#1 Updated by Gerrit Code Review about 5 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33098

#2 Updated by Gerrit Code Review over 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33098

#3 Updated by Gerrit Code Review over 4 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33098

#4 Updated by Gerrit Code Review over 4 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33098

#5 Updated by Susanne Moog over 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#6 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF