Bug #63380
closed
FLUIDTEMPLATE: New fallback paths miss stdWrap
100%
Description
Although documented inside the code and also on docs.typo3.org, the new properties layoutRootPaths and partialRootPaths both currently still miss stdWrap.
Add it!
(Nitpick: Also fix the comment in around line 39 to say "partialRootPaths array of filepaths+stdWrap Root paths to partials")
Updated by Frederic Gaus over 9 years ago
This is not true for the current master. For layoutRootPath the stdWrap is applied in line 132 and for partialRootPath the stdWrap is applied in line 156. So only the phpDoc has to be fixed.
Updated by Gerrit Code Review over 9 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35809
Updated by Frederic Gaus over 9 years ago
Updated by Gerrit Code Review over 9 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35809
Updated by Gerrit Code Review over 9 years ago
Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35816
Updated by Wouter Wolters over 9 years ago
- Status changed from Under Review to Resolved
Updated by Chris topher over 9 years ago
- Status changed from Resolved to New
Frederic Gaus wrote:
For layoutRootPath the stdWrap is applied in line 132 and for partialRootPath the stdWrap is applied in line 156. So only the phpDoc has to be fixed.
Thanks for pushing the patch, guys! However, please double check the exact property names! You are speaking about the properties without plural -s. What I mean are different properties - I mean layoutRootPaths and partialRootPaths - those with plural -s at the end.
These two properties still miss stdWrap!
Updated by Gerrit Code Review almost 9 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41584
Updated by Gerrit Code Review almost 9 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41584
Updated by Gerrit Code Review almost 9 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41584
Updated by Gerrit Code Review almost 9 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41584
Updated by Gerrit Code Review almost 9 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41584
Updated by Gerrit Code Review almost 9 years ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41584
Updated by
Updated by Gerrit Code Review almost 9 years ago
Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41584
Updated by Gerrit Code Review almost 9 years ago
Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41584
Updated by Anja Leichsenring almost 9 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset f16a00ed4fbf10f43582c8894edb4decfe152766.
Updated by Gerrit Code Review almost 9 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41679
Updated by Loek Hilgersom almost 9 years ago
Current solution as implemented and merged in http://review.typo3.org/41584 doesn't work correctly.
cObj->stdWrap calls should be replaced by cObj->cObjGetSingle
Updated by Gerrit Code Review almost 9 years ago
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41820
Updated by Gerrit Code Review almost 9 years ago
Patch set 2 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41679
Updated by Gerrit Code Review almost 9 years ago
Patch set 3 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41679
Updated by Gerrit Code Review almost 9 years ago
Patch set 4 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41679
Updated by Gerrit Code Review over 8 years ago
Patch set 5 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41679
Updated by Anja Leichsenring over 8 years ago
- Status changed from Under Review to Resolved
Applied in changeset fcf6f28dfc6470f3b1bd7316342910dcd9494762.
Updated by