Project

General

Profile

Actions

Bug #63380

closed

FLUIDTEMPLATE: New fallback paths miss stdWrap

Added by Chris topher over 9 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2014-11-27
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

Although documented inside the code and also on docs.typo3.org, the new properties layoutRootPaths and partialRootPaths both currently still miss stdWrap.

Add it!

(Nitpick: Also fix the comment in around line 39 to say "partialRootPaths array of filepaths+stdWrap Root paths to partials")


Related issues 3 (0 open3 closed)

Related to TYPO3 Core - Bug #68416: Recently merged fix for FLUIDTEMPLATE: New fallback paths miss stdWrap doesn't work correctlyClosedLoek Hilgersom2015-07-21

Actions
Related to TYPO3 Core - Bug #70788: Fix wrong stdWrap support for paths in FluidTemplateContentObjectClosedMarkus Klein2015-10-16

Actions
Follows TYPO3 Core - Bug #61361: Fluid template path fallback doesn't work in TypoScript object FLUIDTEMPLATEClosed2014-09-05

Actions
Actions #1

Updated by Chris topher over 9 years ago

  • Description updated (diff)
Actions #2

Updated by Frederic Gaus over 9 years ago

This is not true for the current master. For layoutRootPath the stdWrap is applied in line 132 and for partialRootPath the stdWrap is applied in line 156. So only the phpDoc has to be fixed.

Actions #3

Updated by Gerrit Code Review over 9 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35809

Actions #5

Updated by Gerrit Code Review over 9 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35809

Actions #6

Updated by Gerrit Code Review over 9 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35816

Actions #7

Updated by Wouter Wolters over 9 years ago

  • Status changed from Under Review to Resolved
Actions #8

Updated by Chris topher over 9 years ago

  • Status changed from Resolved to New

Frederic Gaus wrote:

For layoutRootPath the stdWrap is applied in line 132 and for partialRootPath the stdWrap is applied in line 156. So only the phpDoc has to be fixed.

Thanks for pushing the patch, guys! However, please double check the exact property names! You are speaking about the properties without plural -s. What I mean are different properties - I mean layoutRootPaths and partialRootPaths - those with plural -s at the end.

These two properties still miss stdWrap!

Actions #9

Updated by Gerrit Code Review almost 9 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41584

Actions #10

Updated by Gerrit Code Review almost 9 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41584

Actions #11

Updated by Gerrit Code Review almost 9 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41584

Actions #12

Updated by Gerrit Code Review almost 9 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41584

Actions #13

Updated by Gerrit Code Review almost 9 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41584

Actions #14

Updated by Gerrit Code Review almost 9 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41584

Actions #15

Updated by Markus Sommer almost 9 years ago

  • Assignee set to Anja Leichsenring
Actions #16

Updated by Gerrit Code Review almost 9 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41584

Actions #17

Updated by Gerrit Code Review almost 9 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41584

Actions #18

Updated by Anja Leichsenring almost 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #19

Updated by Gerrit Code Review almost 9 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41679

Actions #20

Updated by Loek Hilgersom almost 9 years ago

Current solution as implemented and merged in http://review.typo3.org/41584 doesn't work correctly.

cObj->stdWrap calls should be replaced by cObj->cObjGetSingle

Actions #21

Updated by Gerrit Code Review almost 9 years ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41820

Actions #22

Updated by Gerrit Code Review almost 9 years ago

Patch set 2 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41679

Actions #23

Updated by Gerrit Code Review almost 9 years ago

Patch set 3 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41679

Actions #24

Updated by Gerrit Code Review almost 9 years ago

Patch set 4 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41679

Actions #25

Updated by Gerrit Code Review over 8 years ago

Patch set 5 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41679

Actions #26

Updated by Anja Leichsenring over 8 years ago

  • Status changed from Under Review to Resolved
Actions #27

Updated by Benni Mack almost 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF