Feature #63395

Html5 video poster preview image

Added by Werner Trunk almost 5 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
Start date:
2014-11-28
Due date:
% Done:

100%

PHP Version:
Tags:
Complexity:
no-brainer
Sprint Focus:
Remote Sprint

Description

Hallo
I have created a patch for media content to enable Video preview image "poster" in media in the old fashion way.
So if there is an jpg image in the same folder with the same name as the video file it will be shown with the html5 poster attribute.

videoposter.patch View (992 Bytes) Werner Trunk, 2014-11-28 11:07


Related issues

Related to TYPO3 Core - Feature #67455: Video Content Element (mediace) needs a poster image. Closed 2015-06-15
Related to TYPO3 Core - Feature #37073: additional html5 attributes in new media element Closed 2012-05-10

Associated revisions

Revision 3e9cec79 (diff)
Added by Michael Oehlhof about 4 years ago

[FEATURE] HTML5 video poster preview image

Enable Video preview image "poster" in media in the old fashion way.
If there is a jpg, jpeg or png image in the same folder with the same
name as the video file it will be added with the HTML5 poster attribute.

The file extensions are checked exactly in the order mentioned above.

Resolves: #63395
Releases: master
Change-Id: Ie1008d1d7c2b5cff90a5ad33886e37a06417c568
Reviewed-on: http://review.typo3.org/41608
Tested-by: Mathias Brodala <>
Reviewed-by: Georg Ringer <>
Tested-by: Georg Ringer <>
Reviewed-by: Benni Mack <>
Tested-by: Benni Mack <>

History

#1 Updated by Werner Trunk almost 5 years ago

PS: the patch was created for 6.2.6

#2 Updated by Benni Mack over 4 years ago

  • Target version set to 7.4 (Backend)
  • Sprint Focus set to On Location Sprint

Somebody can pick up the issue, add it to master and get it in. Should be easy.

#3 Updated by Gerrit Code Review over 4 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41608

#4 Updated by Michael Oehlhof over 4 years ago

  • Assignee set to Michael Oehlhof

#5 Updated by Gerrit Code Review over 4 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41609

#6 Updated by Gerrit Code Review over 4 years ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41612

#7 Updated by Werner Trunk over 4 years ago

Hallo
Update:
Sorry, it turned out due to internals of media elements it needs to be:
$poster = preg_replace('/.[^.]*$/', '.jpg', reset($conf['sources']));
instead of
$poster=preg_replace('/.[^.]*$/','.jpg',$conf['sources'][1]);
cause after change videos the index does not start at 1 any more.
Also if there are more then 1 video source with different names the name of the jpg poster file has to match the first video.

#8 Updated by Gerrit Code Review over 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41612

#9 Updated by Gerrit Code Review over 4 years ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41654

#10 Updated by Gerrit Code Review over 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41654

#11 Updated by Susanne Moog about 4 years ago

  • Target version changed from 7.4 (Backend) to 7.5

#12 Updated by Anja Leichsenring about 4 years ago

  • Sprint Focus changed from On Location Sprint to Remote Sprint

#13 Updated by Gerrit Code Review about 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41608

#14 Updated by Gerrit Code Review about 4 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41608

#15 Updated by Gerrit Code Review about 4 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41608

#16 Updated by Michael Oehlhof about 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#17 Updated by Werner Trunk about 4 years ago

hello,

in gerrit #41608 and in the commit 3e9cec79 there is:
$conf['sources'][1]

please see above #note-8 and gerrit #41654 :
reset($conf['sources'])

since I had errors with [1] in a real world project, is this meant to be ?

#18 Updated by Riccardo De Contardi almost 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF