Feature #65866
closed
Fetch extension version from ext_emconf.php if composer.json does not contain version property
100%
Description
Composer itself suggests to not set the version property inside composer.json as it can be calculated from vcs branch/tag properties.
Currently this causes troubles inside of 6.2.x as the version from ext_emconf.php is ignored if a composer.json is present.
The concrete requirements to trigger the bug need more information, as it might not happen in all cases.
First requirement of course is a real composer based installation (composer install in root directory)
Also it might happen only when extension are analyzed by a dependency.
Unfortunatly while preparing the patch I forgot to be more precise on the setup to trigger it.
Updated by Gerrit Code Review about 10 years ago
- Status changed from New to Under Review
Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/37971
Updated by
Updated by Gerrit Code Review about 10 years ago
Patch set 2 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/37971
Updated by Nicole Cordes about 10 years ago
- Target version set to 7.3 (Packages)
- Sprint Focus set to On Location Sprint
Updated by Patrik Karisch about 10 years ago
Happened here too. We have some internal extensions which are installed with composer/installers, they have a version field in ext_emconf.php but not in composer.json. It's very unconventional to require a version field in the composer.json
And the exceptions only happens, if a local extensions has a depends constraint in his ext_emconf.php to such a extension which has a composer.json
Updated by Helmut Hummel about 10 years ago
- Status changed from Under Review to Needs Feedback
Patrik Karisch wrote:
Happened here too. We have some internal extensions which are installed with
composer/installers, they have a version field inext_emconf.phpbut not incomposer.json. It's very unconventional to require a version field in thecomposer.jsonAnd the exceptions only happens, if a local extensions has a depends constraint in his
ext_emconf.phpto such a extension which has acomposer.json
I cannot reproduce this any more. Can you give more information how to reproduce it? Also the exception code would already help to tackle this issue.
Updated by Benni Mack about 10 years ago
- Target version changed from 7.3 (Packages) to 7.4 (Backend)
Updated by Helmut Hummel almost 10 years ago
It is about exception code 1395614959 thrown in ExtensionManagementUtility::getExtensionVersion()
Updated by Helmut Hummel almost 10 years ago
Steps to reproduce:
- Extension "a" has a composer.json without version property, is in the system and activated
- Extension "b" is in the system but inactive and has a dependency to extension "a"
- Activate Extension "b" in the extension manager
Updated by Gerrit Code Review almost 10 years ago
- Status changed from Needs Feedback to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41133
Updated by Gerrit Code Review almost 10 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41133
Updated by Gerrit Code Review almost 10 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41133
Updated by Nicole Cordes almost 10 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 6f88d6cf7abe4597e0b27809775b56477d586ad3.
Updated by Mathias Schreiber almost 10 years ago
- Sprint Focus deleted (
On Location Sprint)
Updated by Riccardo De Contardi over 7 years ago
- Status changed from Resolved to Closed