TYPO3 Core

sysext/extbase/Tests/Unit/Property/PropertyMapperTest.php:194: eval("
sysext/extbase/Tests/Unit/Property/TypeConverter/DateTimeConverterTest.php:394: eval('
sysext/extbase/Tests/Unit/Property/TypeConverter/PersistentObjectConverterTest.php:117: eval("class {$className} extends \\" . \TYPO3\CMS\Extbase\DomainObject\AbstractEntity::class . " {}");
sysext/extbase/Tests/Unit/Property/TypeConverter/PersistentObjectConverterTest.php:119: eval("class {$className} extends \\" . \TYPO3\CMS\Extbase\DomainObject\AbstractValueObject::class . " {}");
sysext/extbase/Tests/Unit/Property/TypeConverter/PersistentObjectConverterTest.php:121: eval("class {$className} {}");
sysext/extbase/Tests/Unit/Validation/ValidatorResolverTest.php:48: eval('class ' . $realClassName . ' implements TYPO3\\CMS\\Extbase\\Validation\\Validator\\ValidatorInterface {
sysext/extbase/Tests/Unit/Validation/ValidatorResolverTest.php:72: eval('class ' . $realClassName . '{}');
sysext/extbase/Tests/Unit/Validation/ValidatorResolverTest.php:85: eval('class ' . $expectedValidatorName . ' implements TYPO3\\CMS\\Extbase\\Validation\\Validator\\ValidatorInterface {
sysext/extbase/Tests/Unit/Validation/ValidatorResolverTest.php:109: eval('class ' . $expectedValidatorName . '{}');
sysext/extbase/Tests/Unit/Validation/ValidatorResolverTest.php:135: eval('namespace ' . $namespace . '; class ' . $className . ' implements \TYPO3\CMS\Extbase\Validation\Validator\ValidatorInterface {
sysext/extbase/Tests/Unit/Validation/ValidatorResolverTest.php:145: eval('namespace TYPO3\\CMS\\Extbase\\Validation\\Validator;' . LF . 'class FooValidator implements \TYPO3\CMS\Extbase\Validation\Validator\ValidatorInterface {
sysext/extbase/Tests/Unit/Validation/ValidatorResolverTest.php:371: eval('namespace TYPO3\CMS\Extbase\Validation\Validator;' . LF . 'class ' . $validatorName . 'Validator implements \TYPO3\CMS\Extbase\Validation\Validator\ValidatorInterface {
sysext/extbase/Tests/Unit/Validation/Validator/StringValidatorTest.php:59: eval('
sysext/extbase/Tests/Unit/Validation/Validator/CollectionValidatorTest.php:107: eval('class ' . $classNameA . '{ public $b = array(); public $integer = 5; }');
sysext/extbase/Tests/Unit/Validation/Validator/CollectionValidatorTest.php:109: eval('class ' . $classNameB . '{ public $a; public $c; public $integer = "Not an integer"; }');
sysext/extbase/Tests/Unit/Validation/Validator/GenericObjectValidatorTest.php:66: eval('class ' . $classNameForObjectWithPrivateProperties . '{ protected $foo = \'foovalue\'; protected $bar = \'barvalue\'; }');
sysext/extbase/Tests/Unit/Validation/Validator/GenericObjectValidatorTest.php:101: eval('class ' . $classNameA . '{ public $b; }');
sysext/extbase/Tests/Unit/Validation/Validator/GenericObjectValidatorTest.php:103: eval('class ' . $classNameB . '{ public $a; }');
sysext/extbase/Tests/Unit/Validation/Validator/GenericObjectValidatorTest.php:123: eval('class ' . $classNameA . '{ public $b; }');
sysext/extbase/Tests/Unit/Validation/Validator/GenericObjectValidatorTest.php:125: eval('class ' . $classNameB . '{ public $a; public $uuid = 0xF; }');
sysext/extbase/Tests/Unit/Validation/Validator/GenericObjectValidatorTest.php:150: eval('class ' . $classNameA . '{ public $b; public $uuid = 0xF; }');
sysext/extbase/Tests/Unit/Validation/Validator/GenericObjectValidatorTest.php:152: eval('class ' . $classNameB . '{ public $a; public $uuid = 0xF; }');
sysext/extbase/Tests/Unit/Validation/Validator/StringLengthValidatorTest.php:172: eval('
sysext/extbase/Tests/Unit/Validation/Validator/StringLengthValidatorTest.php:193: eval('
sysext/extbase/Tests/Unit/SignalSlot/DispatcherTest.php:90: eval('class ' . $slotClassName . ' { function slot($foo, $baz) { $this->arguments = array($foo, $baz); } }');
sysext/extbase/Tests/Unit/SignalSlot/DispatcherTest.php:241: eval('class ' . $slotClassName . ' { function slot($foo, $baz) { $this->arguments = array($foo, $baz); } }');
sysext/extbase/Tests/Unit/Mvc/Controller/AbstractControllerTest.php:27: eval('class ' . $className . ' extends \\' . \TYPO3\CMS\Extbase\Mvc\Controller\AbstractController::class . ' { function getExtensionName() { return $this->extensionName; } }');
sysext/extbase/Tests/Unit/Mvc/Controller/AbstractControllerTest.php:39: eval('namespace ' . NAMESPACE . '; class ' . $className . ' extends \\' . \TYPO3\CMS\Extbase\Mvc\Controller\AbstractController::class . ' { function getExtensionName() { return $this->extensionName; } }');
sysext/extbase/Tests/Unit/Mvc/Controller/ActionControllerTest.php:138: eval('namespace MyVendor\MyPackage\View\MyController; class MyActionMyFormat {}');
sysext/extbase/Tests/Unit/Mvc/View/JsonViewTest.php:240: eval('namespace ' . $namespace . '; class ' . $className . ' {}');
sysext/extbase/Tests/Unit/Persistence/RepositoryTest.php:308: eval('namespace ' . NAMESPACE . '; class ' . $repositoryClassName . ' extends \\TYPO3\\CMS\\Extbase\\Persistence\\Repository {
sysext/extbase/Tests/Unit/Persistence/Generic/Mapper/DataMapperTest.php:61: eval('namespace ' . NAMESPACE . '; class ' . $className . ' extends \\' . \TYPO3\CMS\Extbase\DomainObject\AbstractEntity::class . ' {
sysext/extbase/Tests/Unit/Persistence/Generic/Mapper/DataMapperTest.php:169: eval('namespace ' . NAMESPACE . '; class ' . $className . ' extends \\' . \TYPO3\CMS\Extbase\DomainObject\AbstractEntity::class . ' { public $relationProperty; }');
sysext/extbase/Tests/Unit/Persistence/Generic/Mapper/DataMapperTest.php:174: eval('namespace ' . NAMESPACE . '; class ' . $className2 . ' extends \\' . \TYPO3\CMS\Extbase\DomainObject\AbstractEntity::class . ' { }');
sysext/extbase/Tests/Unit/DomainObject/AbstractEntityTest.php:28: eval('namespace ' . NAMESPACE . '; class ' . $domainObjectName . ' extends \\' . \TYPO3\CMS\Extbase\DomainObject\AbstractEntity::class . ' {
sysext/extbase/Tests/Unit/DomainObject/AbstractEntityTest.php:45: eval('namespace ' . NAMESPACE . '; class ' . $domainObjectName . ' extends \\' . \TYPO3\CMS\Extbase\DomainObject\AbstractEntity::class . ' {
sysext/extbase/Tests/Unit/DomainObject/AbstractEntityTest.php:63: eval('namespace ' . NAMESPACE . '; class ' . $domainObjectName . ' extends \\' . \TYPO3\CMS\Extbase\DomainObject\AbstractEntity::class . ' {
sysext/extbase/Tests/Unit/DomainObject/AbstractEntityTest.php:80: eval('namespace ' . NAMESPACE . '; class ' . $domainObjectName . ' extends \\' . \TYPO3\CMS\Extbase\DomainObject\AbstractEntity::class . ' {
sysext/extbase/Tests/Unit/DomainObject/AbstractEntityTest.php:86: eval('namespace ' . NAMESPACE . '; class ' . $secondDomainObjectName . ' extends \\' . \TYPO3\CMS\Extbase\DomainObject\AbstractEntity::class . ' {

I split up the ticket because is it a bit to much for one review and easier to handle for people.

Oliver Hader wrote:

There are still some eval() calls in Extbase Tests - anybody keen on fixing the last remaining parts?

what is the benefit of doing so? In the end the phpunit framework also does eval when creating mocks …