Task #67754
closed
Cleanup "crop" implementation
0%
Description
For 7.3 an image "crop" functionality got added to the features of TYPO3.
The current implemntation is not really a neat one. Let me point out why.
First a rather strange construct had to get added at at least two different placed in the core:
1. line 106 of ImageViewHelper:
https://git.typo3.org/Packages/TYPO3.CMS.git/blob/refs/heads/TYPO3_7-3:/typo3/sysext/fluid/Classes/ViewHelpers/ImageViewHelper.php#l106
2. method "getImgResource" of "ContentObjectRenderer"
https://git.typo3.org/Packages/TYPO3.CMS.git/blob/refs/heads/TYPO3_7-3:/typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php#l5477
Instead of this solution ContentObjectRenderer and Extbase\Service\Image\ImageService should have get changed to pass any FileReference along to the ImageProcessingService.
For this to work a few issues would have to get taken care of:
1. The "Resource\FileReference" class will require a "process" method similar to that of Resource\File
2. The "Resource\ProcessedFileRepository" will need to take care of both: Resource\File and Resource\FileReference
3. The "Resourcce\Processing\LocalCropScaleMaskHelper" class would have to get modified to take care of a FileReference and use the crop-property of the FileReference if not overruled by configuration.
When those changes get applied cropping would be implemented cleanly at one single location/class.
Updated by Bernhard Kraft almost 9 years ago
Having this change integrated it would also be possible to add custom field to FileReferences and then get them handled from within any slot attaching to the "emitPreProcessFile" signal.
Updated by Frans Saris almost 9 years ago
Maybe we can have another look at this when we proceed with #54229
Updated by Bernhard Kraft almost 9 years ago
#54229 seems something REALLY required.
The current file processing mechanism is mostly unflexible.
For example it is almost impossible to process a file twice.
I used the "preProcess" slot of the FileProcessingService to hook in a custom method. Altough I already modified (overridden) the ImageService class of extbase to pass along the FileReference it seemed almost impossible to process a file two times. Reason:
When a file gets processed it will be put under the processed folder of its storage. When you then need to process the file again it is not possible to retrieve a "Resource\File" object for the processed file by any means (Except large scale xclassing). The ResourceFactory methods for retrieving a file will always return a "ProcessedFile" instance instead.
So for processing the file again I had to create a second Resource-Storage record and have it assigned a different processed folder (alt_processed). Then I could request my alternative Resource-Storage for the already processed file and got a Resource\File object back which I could then process again (and having the result put in _alt_processed).
Updated by
Updated by Riccardo De Contardi over 8 years ago
- Target version changed from 7 LTS to Candidate for Major Version
Updated by Susanne Moog about 5 years ago
- Related to Feature #70858: Add possibility to "hook" into the processing chain added
Updated by Susanne Moog about 5 years ago
- Status changed from New to Closed
As this is a technical ticket with no one working on it for the last 3 years, I'm going to close the issue now. If someone wants to start work on it, pushing a patch will reopen the issue.