Project

General

Profile

Actions

Bug #69055

closed

Locking: File change times are cached

Added by Bernhard Kraft over 8 years ago. Updated over 7 years ago.

Status:
Rejected
Priority:
Could have
Assignee:
Category:
Caching
Start date:
2015-08-14
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

Here the change time of a locking file is determined:

https://git.typo3.org/Packages/TYPO3.CMS.git/blob/refs/heads/TYPO3_6-2:/typo3/sysext/core/Classes/Locking/Locker.php#l186

But according to the PHP manual those times get cached by PHP:

http://php.net/manual/en/function.filectime.php

    Note: The results of this function are cached. See clearstatcache() for more details.

Maybe "clearstatcache()" should get called before determining if to unlink() the cache file.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #67246: Better handling of classes loaded via ext_autoloadClosedWouter Wolters2015-06-02

Actions
Actions #1

Updated by Alexander Opitz over 8 years ago

  • Target version changed from 6.2.15 to 6.2.16
Actions #2

Updated by Riccardo De Contardi almost 8 years ago

  • Target version changed from 6.2.16 to Candidate for patchlevel

in 8.1.1-dev the file typo3/sysext/core/Classes/Locking/SimpleLockStrategy.php contains the same function filectime

Actions #3

Updated by Frank Nägler almost 8 years ago

  • Status changed from New to Accepted
  • Assignee set to Frank Nägler
Actions #4

Updated by Frank Nägler almost 8 years ago

  • Status changed from Accepted to In Progress
Actions #5

Updated by Gerrit Code Review almost 8 years ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48402

Actions #6

Updated by Frank Nägler almost 8 years ago

  • Status changed from Under Review to Needs Feedback

after some discussions, we have one question: Is this a real issue or a theoretical issue?

Actions #7

Updated by Frank Nägler over 7 years ago

  • Status changed from Needs Feedback to Rejected

no feedback since 3 month, issue will be closed for the time being. feel free to reopen or create a new issue.

Actions #8

Updated by Bernhard Kraft over 7 years ago

What kind of feedback would you expect? The issue occured at an installation I worked on. After adding the clearstatcache() it worked again. Of course the issue may have been caused by the NFS setup on the servers ... but after all it wouldn't be a mistake to add the "clearstatcache()".

Actions

Also available in: Atom PDF