Bug #69316: Misleading notes about "Feature: #33071 - Add the http header "Content-Language" when rendering a page" - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #69316

closed

Misleading notes about "Feature: #33071 - Add the http header "Content-Language" when rendering a page"

Added by Viktor Livakivskyi about 9 years ago. Updated about 6 years ago.

Status:

Closed

Priority:

Could have

Assignee:

Category:

Documentation

Target version:

Start date:

2015-08-25

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

Hi,

In changelog of TYPO3 CMS 7.4 is a note about "Content-Language" header: https://docs.typo3.org/typo3cms/extensions/core/latest/Changelog/7.4/Feature-33071-AddTheHttpHeaderContent-LanguageWhenRenderingAPage.html

However, here and also in "What's new" PDF it says about mysterious sys_language_content field, while a change, that brings this feature relies on sys_language_isocode: https://forge.typo3.org/projects/typo3cms-core/repository/revisions/7df807628fc9d4fffb746c1d8aead07b6b2dff56/diff/typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php

It took me some time to find this out, so better fix that note to not force others go my way :)

Related issues 2 (0 open — 2 closed)

Actions

Copy link

Updated by Stephan Großberndt almost 8 years ago

Status changed from New to Accepted

The current link to that documentation page is

https://docs.typo3.org/typo3cms/extensions/core/Changelog/7.4/Feature-33071-AddTheHttpHeaderContent-LanguageWhenRenderingAPage.html

The patch in question is https://review.typo3.org/#/c/40265/

    /**
     * Site content selection uid (can be different from sys_language_uid if content
     * is to be selected from a fall-back language. Depends on sys_language_mode)
     * @var int
     */
    public $sys_language_content = 0;

sys_language_content is a term/property defined in TypoScriptFrontendController (TSFE) which, as the PHPDoc above states, can differ from sys_language_uid.
Nonetheless the term is irritating in the feature description, it should be updated, file in question is /typo3/sysext/core/Documentation/Changelog/7.4/Feature-33071-AddTheHttpHeaderContent-LanguageWhenRenderingAPage.rst in the Branch TYPO3_7-6

Actions

Copy link

Updated by Christian Kuhn almost 7 years ago

Related to Task #83610: Fix documentation for forge issue 69316 added

Actions

Copy link

Updated by Gerrit Code Review almost 7 years ago

Status changed from Accepted to Under Review

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55410

Actions

Copy link