Task #69729

Story #69712: Further FormEngine development

Inline getDynamicTabMenu

Added by Christian Kuhn about 5 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
Start date:
2015-09-12
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
medium
Sprint Focus:
Stabilization Sprint

Description

The "tabbing" in FormEngine is currently done at various (i think container only) places with methods getDynamicTabMenu() and getDynTabMenuId() from DocumentTemplate.

This should be inlined to FormEngine code, probably via method(s) located within AbstractContainer.

It might be a good idea to work on an own template for that, so maybe the ones currently referenced in getDynamicTabMenu could be copied to a location where that is only used by FormEngine.

One important thing is that the existing $this->pageRenderer->loadRequireModule() call vanishes and instead is added to "requireJsModules" of $resultArray: No render element must call pageRenderer directly or inderectly, ever.


Related issues

Related to TYPO3 Core - Task #70440: Add getDynamicTabMenu() to ModuleTemplateClosed2015-10-06

Actions
#1

Updated by Anja Leichsenring about 5 years ago

  • Sprint Focus changed from On Location Sprint to Stabilization Sprint
#2

Updated by Benni Mack about 5 years ago

  • Target version changed from 7.5 to 7 LTS
#3

Updated by Gerrit Code Review about 5 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44269

#4

Updated by Gerrit Code Review about 5 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44269

#5

Updated by Gerrit Code Review about 5 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44269

#6

Updated by Gerrit Code Review about 5 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44269

#7

Updated by Gerrit Code Review about 5 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44269

#8

Updated by Christian Kuhn about 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#9

Updated by Riccardo De Contardi about 3 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF