Actions
Task #69736
closedDrop 'iconsInOptionTags'
Start date:
2015-09-12
Due date:
% Done:
100%
Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
medium
Sprint Focus:
Description
with TCA config 'iconsInOptionTags' sometimes an item icon was rendered within the option tag of select items. This was never valid HTML and only worked in a fraction of browsers.
Task is to remove this option altogether. If we introduce a similar functionality again, it would be solved differently.
- Find out for which elements this was possible, at least for tca type select.
- Extend TcaMigration with a method to drop this option from TCA whereever it may occur. Have this method unit tested.
- Add a "important" (?) .rst file that this option vanished.
- Add a pull request to ext:styleguide removing examples that use this option.
- Find according code within FormEngine classes that use this method.
- FormEngineUtility::optionTagStyle() method will be unused afterwards. The method is "internal" and can be dropped without substitution.
Updated by Mathias Brodala about 9 years ago
- Status changed from New to In Progress
Updated by Gerrit Code Review about 9 years ago
- Status changed from In Progress to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43251
Updated by Gerrit Code Review about 9 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43251
Updated by Mathias Brodala about 9 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 53a7425282d13db55d853ee918df2f206b74a6d3.
Updated by Anja Leichsenring almost 9 years ago
- Sprint Focus deleted (
On Location Sprint)
Updated by Riccardo De Contardi about 7 years ago
- Status changed from Resolved to Closed
Actions