Task #69736

Drop 'iconsInOptionTags'

Added by Christian Kuhn about 5 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
Start date:
2015-09-12
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
medium
Sprint Focus:

Description

with TCA config 'iconsInOptionTags' sometimes an item icon was rendered within the option tag of select items. This was never valid HTML and only worked in a fraction of browsers.

Task is to remove this option altogether. If we introduce a similar functionality again, it would be solved differently.

  • Find out for which elements this was possible, at least for tca type select.
  • Extend TcaMigration with a method to drop this option from TCA whereever it may occur. Have this method unit tested.
  • Add a "important" (?) .rst file that this option vanished.
  • Add a pull request to ext:styleguide removing examples that use this option.
  • Find according code within FormEngine classes that use this method.
  • FormEngineUtility::optionTagStyle() method will be unused afterwards. The method is "internal" and can be dropped without substitution.

Related issues

Related to TYPO3 Core - Task #69792: Bring back icons before select fieldsClosedMathias Brodala2015-09-14

Actions
#1

Updated by Christian Kuhn about 5 years ago

  • Description updated (diff)
#2

Updated by Mathias Brodala about 5 years ago

  • Assignee set to Mathias Brodala
#3

Updated by Mathias Brodala about 5 years ago

  • Status changed from New to In Progress
#4

Updated by Gerrit Code Review about 5 years ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43251

#5

Updated by Gerrit Code Review about 5 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43251

#6

Updated by Mathias Brodala about 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#7

Updated by Anja Leichsenring almost 5 years ago

  • Sprint Focus deleted (On Location Sprint)
#8

Updated by Riccardo De Contardi about 3 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF