Task #69749

Introduce caching for record titles

Added by Nicole Cordes over 4 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
-
Target version:
Start date:
2015-09-13
Due date:
% Done:

100%

TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

The title of a record is fetched multiple times inside the core. We should cache the compiled title according to the function parameter.


Related issues

Related to TYPO3 Core - Task #69721: Inline BackendUtility::getRecordTitle as data provider Closed 2015-09-12
Related to TYPO3 Core - Bug #70435: IRRE foreign_selector with useCombination on save does not update label in select list of foreign_selector Closed 2015-10-06

Associated revisions

Revision d10070e8 (diff)
Added by Nicole Cordes over 4 years ago

[TASK] Introduce caching for record titles

The title of a record is fetched multiple times inside the core.
The patch introduces an internal caching according to record and
method parameters.

Resolves: #69749
Related: #69721
Releases: master
Change-Id: I7c0b227872f9ce552d3bf4cce7d6460f4f0b3db2
Reviewed-on: http://review.typo3.org/43259
Reviewed-by: Stephan Großberndt <>
Tested-by: Stephan Großberndt <>
Reviewed-by: Jan Helke <>
Reviewed-by: Mathias Brodala <>
Tested-by: Mathias Brodala <>
Reviewed-by: Nicole Cordes <>
Tested-by: Nicole Cordes <>

Revision f8284825 (diff)
Added by Christian Kuhn over 4 years ago

[BUGFIX] Remove getRecordTitle() runtime cache

This reverts the runtime cache of BackendUtility::getRecordTitle()
from commit d10070e81. This low level method is getting more and
more unused anyway and is substituted with a data provider in
FormEngine for example. The cache currently introduces issues
in edge cases and the benefit of the cache in general in rather
small.

Resolves: #70435
Related: #69749
Releases: master
Change-Id: Id9f352a2193f38fafc305001a2d20db16298b2fd
Reviewed-on: https://review.typo3.org/44241
Reviewed-by: Jan Helke <>
Tested-by: Jan Helke <>
Reviewed-by: Mathias Schreiber <>
Tested-by: Mathias Schreiber <>
Reviewed-by: Stefan Neufeind <>
Tested-by: Stefan Neufeind <>

History

#1 Updated by Gerrit Code Review over 4 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43259

#2 Updated by Nicole Cordes over 4 years ago

  • Target version set to 7.5
  • Sprint Focus set to On Location Sprint

#3 Updated by Gerrit Code Review over 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43259

#4 Updated by Gerrit Code Review over 4 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43259

#5 Updated by Gerrit Code Review over 4 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43259

#6 Updated by Gerrit Code Review over 4 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43259

#7 Updated by Gerrit Code Review over 4 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43259

#8 Updated by Nicole Cordes over 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#9 Updated by Christian Kuhn over 4 years ago

  • Status changed from Resolved to New
  • % Done changed from 100 to 0

#10 Updated by Christian Kuhn over 4 years ago

This is still an open issue, as discussed with morton and nicole, the getRecordTitle() code still needs to be moved over to a formengine data provider.

#11 Updated by Christian Kuhn over 4 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100

ok, mixed it up. this one is resolved, the other one is still open.

#12 Updated by Anja Leichsenring about 4 years ago

  • Sprint Focus deleted (On Location Sprint)

#13 Updated by Riccardo De Contardi over 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF