Task #69721

Story #69712: Further FormEngine development

Inline BackendUtility::getRecordTitle as data provider

Added by Christian Kuhn about 5 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Should have
Category:
FormEngine aka TCEforms
Target version:
Start date:
2015-09-12
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
hard
Sprint Focus:

Description

BackendUtility::getRecordTitle() is used within FormEngine at various places. It does tons of different data fetching operations and is in general a rather huge headache.

Get rid of this in FormEngine scope:

  • Add a "recordTitle" field to the data array in FormDataCompiler that can be used by render part.
  • Extend removeObsoleteColumns() in TcaTypesShowItem method to not remove fields that are used in one of the title ctrl fields mentioned in getRecordTitle. Maybe extract this method to an own provider that is executed right after TcaTypesShowItem provider. This has the effect, that the following field specific providers like TcaSelect and friends will calculated items and values for fields that are used within title, but that are now within showitem, too.
  • Add a provider that is executed after the Tca* providers that fills the "recordTitle" field of the data array.

Related issues

Related to TYPO3 Core - Task #69749: Introduce caching for record titlesClosedNicole Cordes2015-09-13

Actions
#1

Updated by Christian Kuhn about 5 years ago

  • Complexity changed from medium to hard
#2

Updated by Nicole Cordes about 5 years ago

  • Assignee set to Nicole Cordes
#3

Updated by Nicole Cordes about 5 years ago

  • Status changed from New to Needs Feedback

Hey Christian,

I had a look at the used BackendUtility::getRecordTitle and had to confess that the title is crawled for related records (e.g. parent page, inline elements) but not for the record itself. IMHO we cannot get rid of the calls of getRecordTitle but maybe we should introduce an internal caching in there.

#4

Updated by Christian Kuhn about 5 years ago

  • Status changed from Needs Feedback to New

Still needs to be tackled. getRecordTitle within FormEngine usage should vanish and substituted by some proper data providing ... not 100% sure about all details, though.

#5

Updated by Christian Kuhn about 5 years ago

  • Assignee deleted (Nicole Cordes)

Morton picked up this topic.

#6

Updated by Anja Leichsenring about 5 years ago

  • Sprint Focus changed from On Location Sprint to Stabilization Sprint
#7

Updated by Morton Jonuschat about 5 years ago

  • Category set to FormEngine aka TCEforms
  • Status changed from New to In Progress
  • Assignee set to Morton Jonuschat
#8

Updated by Gerrit Code Review about 5 years ago

  • Status changed from In Progress to Under Review

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43485

#9

Updated by Gerrit Code Review about 5 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43485

#10

Updated by Gerrit Code Review about 5 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43485

#11

Updated by Gerrit Code Review about 5 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43485

#12

Updated by Benni Mack about 5 years ago

  • Target version changed from 7.5 to 7 LTS
  • Sprint Focus deleted (Stabilization Sprint)
#13

Updated by Gerrit Code Review about 5 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43485

#14

Updated by Gerrit Code Review about 5 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43485

#15

Updated by Gerrit Code Review about 5 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43485

#16

Updated by Gerrit Code Review about 5 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43485

#17

Updated by Gerrit Code Review about 5 years ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43485

#18

Updated by Morton Jonuschat about 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#19

Updated by Riccardo De Contardi about 3 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF