Project

General

Profile

Actions

Bug #72704

closed

Global RequireJS modules must not be loaded multiple times

Added by Markus Klein almost 9 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Must have
Category:
Backend API
Target version:
Start date:
2016-01-14
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

There are several JS modules which are subject to be loaded only once in a context (eg the BE).
These modules must also be loadable in other contexts like popups and iframes.

Since the PHP code usually does not know in which context is gets loaded (module frame or popup), it will of course always load the JS modules, which is ok.
The modules, though, must check if it has already been loaded a more global scope and must then return this very instance.

The basic principle has already been implemented for Storage.js and can be copied for other JS modules.

The localization labels, currently created dynamically in PHP, are a special case, which should be handled in a dedicated issue.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #72739: ImageManipulation wizard is brokenClosedFrank Nägler2016-01-15

Actions
Actions #1

Updated by Gerrit Code Review almost 9 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45893

Actions #2

Updated by Gerrit Code Review almost 9 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45893

Actions #3

Updated by Gerrit Code Review almost 9 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45893

Actions #4

Updated by Gerrit Code Review almost 9 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45893

Actions #5

Updated by Gerrit Code Review almost 9 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45893

Actions #6

Updated by Gerrit Code Review almost 9 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45893

Actions #7

Updated by Anja Leichsenring almost 9 years ago

  • Sprint Focus set to On Location Sprint
Actions #8

Updated by Gerrit Code Review almost 9 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45893

Actions #9

Updated by Gerrit Code Review almost 9 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45893

Actions #10

Updated by Gerrit Code Review almost 9 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45893

Actions #11

Updated by Gerrit Code Review almost 9 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45893

Actions #12

Updated by Gerrit Code Review almost 9 years ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45893

Actions #13

Updated by Gerrit Code Review almost 9 years ago

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45944

Actions #14

Updated by Anja Leichsenring almost 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #15

Updated by Mathias Schreiber over 8 years ago

  • Sprint Focus deleted (On Location Sprint)
Actions #16

Updated by Riccardo De Contardi about 7 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF