Feature #75572
closed
Filetype icons - add missing common filetype icons
0%
Description
In file links with view file name and file extension icon there are missing icons, e.g. mp4, docx .... (didn´t test all file types)
Files
Updated by Riccardo De Contardi over 8 years ago
- Status changed from New to Needs Feedback
Hello.
Can you tell us more about how to reproduce your problem? What steps did you follow? Do you use Css Styled Content? Fluid Styled Content? Could you attach a screenshot? Thank you
Updated by Carla Froitzheim over 8 years ago
- File filelinks_icons.jpg filelinks_icons.jpg added
I am using FSC. I use the content element file links and under appearance in the drop down "Display file/icon/thumbnail" I use "file name and file extension icon". In one case I have a file collection type folder from storage, in the second case I have a file collection type static collection of files. I noticed that some icons (tested mp4 and docx) seem to be missing, see screenshot.
Updated by Riccardo De Contardi over 8 years ago
I think that the problem is: there is no icon for those file extension. If I understand correctly, the icons are located on /typo3/sysext/frontend/Resources/Public/Icons/FileIcons/
the FSC template Uploads.html reads:
<f:if condition="{data.uploads_type} == 1">
<img src="{f:uri.resource(path: 'Icons/FileIcons/{file.extension}.gif', extensionName: 'frontend')}" alt="">
</f:if>
(and there is a similar section below for
data.uploads_type=2)
as far as I can see there is no fallback to use default.gif for unrecognized file types.
My suggestion is to modify the template and use a set of icons of yours (I would better use CSS and a sprite).
Otherwise, if you agree, I would change this issue title to "Filetype icons - add missing common filetype icons" and tracker to "Feature"... the problem is that there will for sure be debate about what file extension should be considered "common" enough to include, I think. The fallback for unrecognized filetype icons would be a nice add, but I don't know if it would be possible in FSC.
(BTW: that would be possible using CSS)
Updated by Carla Froitzheim over 8 years ago
I agree to change the issue title and tracker to feature.
Updated by Riccardo De Contardi over 8 years ago
- Tracker changed from Bug to Feature
- Subject changed from Icons missing in file links with icon view to Filetype icons - add missing common filetype icons
- Category set to Frontend
- Status changed from Needs Feedback to New
- Priority changed from Should have to Could have
- Target version set to Candidate for Major Version
As agreed with the author of the issue, I change this issue into "feature"
The main topics related to this feature are:
- add "common" filetype icons (To be decided: what are the "common" ones)
- add a "fallback" feature: the unrecognized file types should have the "default.gif" icon, even with FSC. as far as now, there is no such fallback
- explore the possibility of using a sprite for the icons and pure CSS background-image icons, related to the file extension.
Updated by Marco Huber almost 8 years ago
There is a nice patch which uses the icons in typo3/sysext/core/Resources/Public/Icons/T3Icons/mimetypes, but sadly the patch was abandoned: https://review.typo3.org/#/c/44464/
But the viewhelper in this patch works, so you could use it in your own theme extension.
Updated by Riccardo De Contardi over 3 years ago
- Related to Feature #93780: New File Icons for Uploads added
Updated by Riccardo De Contardi over 3 years ago
- Related to Task #94952: Additional File-Links icons added
Updated by Georg Ringer 6 months ago
- Status changed from New to Closed
closed in favor of #93780 - I totally agree that the icons need to have a better look and need to be updated