Bug #76120
closed
rsaauth does not submit the name of the submit-button
0%
Description
Currently rsaauth does not submit the name of the clicked submit-button. If a form has multiple submit buttons, the name is needed to differentiate on the server-side which button was clicked.
This happens because rsaauth calls preventDefault on the submit-event and then resubmits the form (without adding the submit-button name):
https://github.com/TYPO3/TYPO3.CMS/blob/a8ca5f0e7447610c10b4dfad04919f0864ebc950/typo3/sysext/rsaauth/Resources/Public/JavaScript/RsaEncryption.js#L111
This leads to a bug in sr_feuser_register which prevents editing of user-data. The Controller looks, if the name of the submit-button is within the POST-Data to check if the form was submitted.
A fix might be to remember the last-clicked submit-button in the form before preventing the submit-event. If no button was clicked (when the user pressed enter in a form field), the name of the first found submit-button should be used. This is the default browser-behavior.
Updated by Gerrit Code Review almost 8 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48371
Updated by Gerrit Code Review over 7 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48371
Updated by Gerrit Code Review over 6 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48371
Updated by Gerrit Code Review about 6 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48371
Updated by Gerrit Code Review about 6 years ago
Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56088
Updated by Nicole Cordes about 6 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 0483c4af5c0441e56322bfa1d882578cbbe71110.
Updated by Gerrit Code Review about 6 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56104
Updated by Gerrit Code Review about 6 years ago
Patch set 2 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56104
Updated by Gerrit Code Review about 6 years ago
Patch set 3 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56104
Updated by Gerrit Code Review about 6 years ago
Patch set 4 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56104
Updated by Gerrit Code Review about 6 years ago
Patch set 5 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56104
Updated by Nicole Cordes about 6 years ago
- Status changed from Under Review to Resolved
Applied in changeset 1bd63f45ba90eeb6b52e435546bcd7b97a8deaa6.
Updated by Markus Klein about 6 years ago
- Related to Bug #84253: BE Login with 8.7.11 and Firefox Quantum Browser Version 59.0 not possible anymore added
Updated by Markus Klein about 6 years ago
- Related to Bug #84308: Submit of RSA encrypted form not working with type="image" in TYPO3 8.7.11 added
Updated by Oliver Hader about 6 years ago
- Related to Bug #84503: Streamline RsaAuth login behavior added
Updated by Markus Klein about 6 years ago
- Status changed from Resolved to New
- % Done changed from 100 to 0
The patches have been reverted due to regressions. Hence the ticket reopened
Updated by Oliver Hader about 6 years ago
Draft of handling multiple buttons, see https://review.typo3.org/#/c/56412/
Updated by Oliver Hader over 5 years ago
- Status changed from New to Rejected
RSA auth is only necessary in non-SSL setups. EXT:rsaauth won't be part of TYPO3 core v10 anymore, as its concepts are wrong.
Multiple buttons should be handled more explicitly by adjusting the according markup.