Project

General

Profile

Actions

Bug #76661

closed

Suggest Wizard ajax response ignores columnsOverrides

Added by Daniel Siepmann almost 8 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
FormEngine aka TCEforms
Target version:
-
Start date:
2016-06-16
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
7.0
Tags:
Complexity:
medium
Is Regression:
No
Sprint Focus:

Description

We override the records fields with different configuration.
That works on Rendering the BE-Form, but isn't taken into account while processing the ajax of suggest wizard. He only takes a look at the TCA, without the overwrites and is not usable. The only way to prevent insertions of invalid records is to disable the wizard via columnsOverrides.

Configuration is attached as screenshots, here is the example for copy and paste:

                        'columnsOverrides' => [
                            'records' => [
                                'config' => [
                                    'minitems' => 1,
                                    'foreign_table' => 'fe_users',
                                    'allowed' => 'fe_users',
                                    'wizards' => [
                                        'suggest' => [
                                            'default' => [
                                                'pidList' => '2',
                                                'searchCondition' => 'pid = 2',
                                                'searchWholePhrase' => 1,
                                                'additionalSearchFields' => 'username, city, country',
                                            ],
                                        ],
                                    ],
                                ],
                            ],
                        ],

For 7.6.9 the following line is used to fetch configuration:

        $fieldConfig = $GLOBALS['TCA'][$table]['columns'][$field]['config'];
        $this->overrideFieldNameAndConfigurationForFlexform($table, $field, $row, $fieldConfig);

        $wizardConfig = $fieldConfig['wizards']['suggest'];

        $queryTables = $this->getTablesToQueryFromFieldConfiguration($fieldConfig);
        $whereClause = $this->getWhereClause($fieldConfig);

sysext/backend/Classes/Form/Wizard/SuggestWizard.php

So the configuration is ignored.


Files

Screen Shot 2016-06-16 at 15.04.24.png (31.9 KB) Screen Shot 2016-06-16 at 15.04.24.png TYPO3 default records configuration Daniel Siepmann, 2016-06-16 15:09
Screen Shot 2016-06-16 at 15.04.27.png (37.2 KB) Screen Shot 2016-06-16 at 15.04.27.png Overwrite of records configuration Daniel Siepmann, 2016-06-16 15:09
Screenshot from 2020-04-07 10-06-25.png (72 KB) Screenshot from 2020-04-07 10-06-25.png Daniel Siepmann, 2020-04-07 11:02
Screenshot from 2020-04-07 10-06-36.png (130 KB) Screenshot from 2020-04-07 10-06-36.png Daniel Siepmann, 2020-04-07 11:02

Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #86876: TCA columnsOverrides ignores default valueClosed2018-11-07

Actions
Actions #1

Updated by Björn Jacob over 7 years ago

  • Category changed from Form Framework to FormEngine aka TCEforms
  • Sprint Focus set to On Location Sprint
Actions #2

Updated by Susanne Moog almost 7 years ago

  • Complexity set to medium
Actions #3

Updated by Anja Leichsenring over 6 years ago

  • Sprint Focus deleted (On Location Sprint)
Actions #4

Updated by R3 H6 almost 6 years ago

Can confirm this bug in TYPO3 8.7

Actions #5

Updated by Daniel Siepmann over 5 years ago

We again hit this limitation in another project for current CMS v 8.7.20. Looks like the JavaScript needs adjustment, to provide the current Type (CType in case of tt_content). This way the suggest wizard can either simulate the data to use the existing FormDataProvider TcaColumnsOverrides, or can look up any overrides itself, which would lead to duplicate knowledge about structure.

Otherwise the type can be fetched from DB, in assumption that the record was already saved.

Actions #6

Updated by Gerrit Code Review over 5 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59444

Actions #7

Updated by Gerrit Code Review over 5 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59444

Actions #8

Updated by Gerrit Code Review over 5 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59444

Actions #9

Updated by Daniel Siepmann about 5 years ago

  • Related to Bug #86876: TCA columnsOverrides ignores default value added
Actions #10

Updated by Gerrit Code Review almost 5 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59444

Actions #11

Updated by Gerrit Code Review over 4 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59444

Actions #12

Updated by Gerrit Code Review about 4 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59444

Actions #14

Updated by Gerrit Code Review about 4 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59444

Actions #15

Updated by Daniel Siepmann about 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #16

Updated by Daniel Siepmann about 4 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF