Project

General

Profile

Actions
Copy link

Feature #77108

closed

Defining a complete interface version of ResourceStorageInterface

Added by Lars Tode about 8 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
File Abstraction Layer (FAL)
Target version:
-
Start date:
2016-07-15
Due date:
% Done:

0%

Estimated time:
PHP Version:
Tags:
Complexity:
medium
Sprint Focus:

Description

Last week we tried to create an own ResourceStorage as close as possibile to the TYPO3 core.

During the check of the internal interface for the ResourceStorage (typo3/sysext/core/Classes/Resource/ResourceStorageInterface.php) we figured out, that the interface does not define any kind of methods.

The current implementation of the ResourceStorage (typo3/sysext/core/Classes/Resource/ResourceStorage.php) has a lot of public methods.

The public methods in class ResourceStorage should be checked if they can be used for the ResourceStorageInterface.

Additionaly the arguments of the methods should refer to the interfaces instead of the implementation of an interface.

Example


/**
 * Assures read permission for given folder.
 *
 * @param Folder $folder If a folder is given, mountpoints are checked. If not only user folder read permissions are checked.
 * @return void
 * @throws Exception\InsufficientFolderAccessPermissionsException
 */
protected function assureFolderReadPermission(Folder $folder = null)
{
    // Here some code
}

What could be an issue are classes who implements these interfaces and did not fullfil the new method signature.

Actions
Copy link

Also available in: Atom PDF