Feature #78590
closed
Custom backend logo: width and size for svg files
100%
Description
Problem/Description¶
getimagesize() tries to get width and height of an custom backend logo. But that's not possible on svg files as there is no height or width. A custom svg logo is actually rendered without height/width attributes.
I suggest to add support for width/height attributes via the filename. With that change, it's possible to add wide backend logos also with svg file formats.
ToDo(s)¶
- Extend
\TYPO3\CMS\Backend\Controller\BackendController::render()to check for pattern "w123h123" in the filename if the custom logo is svg.- Fallback to the default backend logo size of 22x22px if no dimensions are given for the custom svg icon.
- Add Feature rst file
Updated by Gerrit Code Review over 7 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50522
Updated by Gerrit Code Review over 7 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50522
Updated by Gerrit Code Review over 7 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50522
Updated by Frans Saris over 7 years ago
- Status changed from Under Review to Needs Feedback
The core provides a class the get the image dimensions.
$imageInfo = GeneralUtility::makeInstance(FileType\ImageInfo::class, $fileNameAndPath);
Can this be a solution for getting the dimensions?
See https://github.com/TYPO3/TYPO3.CMS/blob/6c21ec7b58ca547eb1d908ee289dd1732313a90d/typo3/sysext/core/Classes/Resource/Index/MetaDataRepository.php#L69 for an example
Updated by Gerrit Code Review over 7 years ago
- Status changed from Needs Feedback to Under Review
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50522
Updated by Gerrit Code Review over 7 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50522
Updated by Gerrit Code Review over 7 years ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50522
Updated by Gerrit Code Review over 7 years ago
Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50522
Updated by Gerrit Code Review over 7 years ago
Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50522
Updated by Gerrit Code Review over 7 years ago
Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50522
Updated by Gerrit Code Review over 7 years ago
Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50690
Updated by Anonymous over 7 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset b93845f4e4c0092c36090cd3de52ea2816220e11.
Updated by Gerrit Code Review over 7 years ago
- Status changed from Resolved to Under Review
Patch set 2 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50690
Updated by Gerrit Code Review over 7 years ago
Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50864
Updated by Georg Ringer over 7 years ago
- Status changed from Under Review to Resolved
Applied in changeset 53a94aa4bfe43645df998a785c427bb9527cc671.
Updated by Riccardo De Contardi over 6 years ago
- Status changed from Resolved to Closed