Task #78600: Replace getimagesize() by \TYPO3\CMS\Core\Type\File\ImageInfo() - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Task #78600

closed

Replace getimagesize() by \TYPO3\CMS\Core\Type\File\ImageInfo()

Added by Frans Saris over 7 years ago. Updated over 5 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Markus Klein

Category:

Image Generation / GIFBUILDER

Target version:

Start date:

2016-11-07

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

no-brainer

Sprint Focus:

Description

The php method getimagesize() doesn't support all moderns file types like svg that's why \TYPO3\CMS\Core\Type\File\ImageInfo() was introduced.

Replace all getimagesize() calls throughout the core to increase image support.


                $imageInfo = GeneralUtility::makeInstance(FileType\ImageInfo::class, $fileNameAndPath);
                $imageDimensions = array(
                    'width' => $imageInfo->getWidth(),
                    'height' => $imageInfo->getHeight(),
                );

Related issues 4 (0 open — 4 closed)

Actions

Copy link

Updated by Riccardo De Contardi over 7 years ago

Category set to Code Cleanup

Actions

Copy link

Updated by Markus Klein about 6 years ago

Category changed from Code Cleanup to Image Generation / GIFBUILDER
Status changed from New to Accepted
Assignee set to Markus Klein
Complexity set to no-brainer

Should also get a fallback to GD if IM/GM are not available.

Actions

Copy link

Updated by Markus Klein about 6 years ago

Related to Feature #20107: Image Resizing / Thumbnails with GD2 instead of ImageMagick added

Actions

Copy link

Updated by Gerrit Code Review about 6 years ago

Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56622

Actions

Copy link

Updated by Gerrit Code Review about 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56622

Actions

Copy link

Updated by Gerrit Code Review about 6 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56724

Actions

Copy link

Updated by Gerrit Code Review about 6 years ago

Patch set 2 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56724

Actions

Copy link

Updated by Markus Klein about 6 years ago

Status changed from Under Review to Resolved
% Done changed from 0 to 100

Applied in changeset 2fb7be7b073657f80fcd4d78cccb2ecf97075fdb.

Actions

Copy link

Updated by Gerrit Code Review almost 6 years ago

Status changed from Resolved to Under Review

Patch set 3 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56724

Actions

Copy link

#10

Updated by Gerrit Code Review almost 6 years ago

Patch set 4 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56724

Actions

Copy link

#11

Updated by Gerrit Code Review almost 6 years ago

Patch set 5 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56724

Actions

Copy link

#12

Updated by Gerrit Code Review almost 6 years ago

Patch set 6 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56724

Actions

Copy link

#13