Bug #78628: selectTree pageTsConfig addItems broken - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #78628

closed

Story #69617: FormEngine bugs

selectTree pageTsConfig addItems broken

Added by Christian Kuhn over 7 years ago. Updated over 5 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Target version:

Start date:

2016-11-09

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

hard

Is Regression:

Sprint Focus:

Description

TCEFORM.tx_styleguide_elements_select.select_tree_1.addItems.staticFromPageTs = 12345

TCEFORM.pages.categories.addItems.staticFromPageTs = 12345

does not work anymore since patch for #70956

moving the line

$fieldConfig['config']['items'] = $this->addItemsFromPageTsConfig($result, $fieldName, $fieldConfig['config']['items']);

up again, effectively reverting the change from #70956 with patch https://review.typo3.org/#/c/44570/4, and the additional ts config item is displayed in 7.6 again. This needs some thoughts on the correct solution in 7.6, then.

However, the issue is more severe in master: it seems the svg tree doesn't handle 'multiple roots' at all at the moment, see SvgTree.js ~197:

if (Array.isArray(json)) {
//little hack, so we can use json structure prepared by ExtJsJsonTreeRenderer
json = json⁰;
}

with additional items, there is [0] and [1] and maybe more. I guess, the other 'static items' eg. from TCA ['config']['items'] won't work either.

Files

tree-viewport-2.png (20.3 KB) tree-viewport-2.png

Christian Kuhn, 2016-11-11 16:43

Related issues 3 (0 open — 3 closed)

Actions

Copy link

Updated by Christian Kuhn over 7 years ago

Description updated (diff)

Actions

Copy link

Updated by Gerrit Code Review over 7 years ago

Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50565

Actions

Copy link

Updated by Gerrit Code Review over 7 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50565

Actions

Copy link

Updated by Gerrit Code Review over 7 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50565

Actions

Copy link

Updated by Gerrit Code Review over 7 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50565

Actions

Copy link

Updated by Christian Kuhn over 7 years ago

File tree-viewport.png added

Actions

Copy link

Updated by Christian Kuhn over 7 years ago

File deleted (~~tree-viewport.png~~)

Actions

Copy link

Updated by Christian Kuhn over 7 years ago

File tree-viewport-2.png tree-viewport-2.png added

Actions

Copy link

Updated by Gerrit Code Review over 7 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50565

Actions

Copy link

#10

Updated by Gerrit Code Review over 7 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50565

Actions

Copy link

#11

Updated by Gerrit Code Review over 7 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50565

Actions

Copy link

#12

Updated by Gerrit Code Review over 7 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50565

Actions

Copy link

#13

Updated by Gerrit Code Review over 7 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50565

Actions

Copy link

#14