Bug #78628

Story #69617: FormEngine bugs

selectTree pageTsConfig addItems broken

Added by Christian Kuhn almost 5 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2016-11-09
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
hard
Is Regression:
No
Sprint Focus:

Description

TCEFORM.tx_styleguide_elements_select.select_tree_1.addItems.staticFromPageTs = 12345

or

TCEFORM.pages.categories.addItems.staticFromPageTs = 12345

does not work anymore since patch for #70956

moving the line

$fieldConfig['config']['items'] = $this->addItemsFromPageTsConfig($result, $fieldName, $fieldConfig['config']['items']);

up again, effectively reverting the change from #70956 with patch https://review.typo3.org/#/c/44570/4, and the additional ts config item is displayed in 7.6 again. This needs some thoughts on the correct solution in 7.6, then.

However, the issue is more severe in master: it seems the svg tree doesn't handle 'multiple roots' at all at the moment, see SvgTree.js ~197:

if (Array.isArray(json)) {
//little hack, so we can use json structure prepared by ExtJsJsonTreeRenderer
json = json0;
}

with additional items, there is [0] and [1] and maybe more. I guess, the other 'static items' eg. from TCA ['config']['items'] won't work either.


Files

tree-viewport-2.png (20.3 KB) tree-viewport-2.png Christian Kuhn, 2016-11-11 16:43

Related issues

Related to TYPO3 Core - Bug #70956: Behavior of keepItems changedClosedMorton Jonuschat2015-10-22

Actions
Related to TYPO3 Core - Task #78744: TCA tree refactoringClosed2016-11-18

Actions
Related to TYPO3 Core - Bug #78747: pageTsConfig addItems still brokenClosed2016-11-18

Actions
#1

Updated by Christian Kuhn almost 5 years ago

  • Description updated (diff)
#2

Updated by Gerrit Code Review almost 5 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50565

#3

Updated by Gerrit Code Review almost 5 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50565

#4

Updated by Gerrit Code Review almost 5 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50565

#5

Updated by Gerrit Code Review almost 5 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50565

#6

Updated by Christian Kuhn almost 5 years ago

  • File tree-viewport.png added
#7

Updated by Christian Kuhn almost 5 years ago

  • File deleted (tree-viewport.png)
#9

Updated by Gerrit Code Review almost 5 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50565

#10

Updated by Gerrit Code Review almost 5 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50565

#11

Updated by Gerrit Code Review almost 5 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50565

#12

Updated by Gerrit Code Review almost 5 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50565

#13

Updated by Gerrit Code Review almost 5 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50565

#14

Updated by Frank Naegler almost 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#15

Updated by Benni Mack about 3 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF