Bug #78984
closed
Missing translation of help text in TCA select renderType=selectCheckBox
100%
Description
The fourth value of TCA select items is an optional description text (see TCA Reference 7.6 / 8-dev).
This text is not translated in Version 7.6 and 8-dev.
Suggested patch for version 7.6:
Index: sysext/backend/Classes/Form/FormDataProvider/AbstractItemProvider.php
<+>UTF-8
===================================================================
--- sysext/backend/Classes/Form/FormDataProvider/AbstractItemProvider.php (revision )
+++ sysext/backend/Classes/Form/FormDataProvider/AbstractItemProvider.php (revision )
@@ -1228,7 +1228,7 @@
}
$value = strlen((string)$item[1]) > 0 ? $item[1] : '';
$icon = $item[2] ?: null;
- $helpText = $item[3] ?: null;
+ $helpText = $languageService->sL(trim($item[3])) ?: null;
$itemArray[$key] = [
$label,
$value,
Updated by Georg Tiefenbrunn over 7 years ago
- Priority changed from Should have to Must have
- TYPO3 Version changed from 7 to 8
Updated by Riccardo De Contardi almost 7 years ago
AFAICS still present in version 9.0.0-dev (latest master) - see sysext/backend/Classes/Form/FormDataProvider/AbstractItemProvider.php, line 1290:
$helpText = $item[3] ?: null;
Updated by Sybille Peters over 6 years ago
Thank you for your report.
Even though it has been some time, would you consider checking if your patch idea is still up to date and upload it to our Gerrit review server?
Someone could do this for you, but I am thinking you might like the opportunity to contribute to TYPO3 yourself.
You can find a description of the TYPO3 contribution workflow here: https://docs.typo3.org/typo3cms/ContributionWorkflowGuide/
Hint: If you get stuck anywhere, ask on Slack in the #typo3-cms-coredev channel. You can register in the TYPO3 slack workspace here: https://forger.typo3.com/slack
Also, if your issue is no longer reproducable, please let us know in the slack channel, so that this issue can be closed.
Thank you in advance!
Sybille
Updated by Gerrit Code Review over 6 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56689
Updated by Gerrit Code Review over 6 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56689
Updated by Gerrit Code Review over 6 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56689
Updated by Georg Ringer over 6 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 939dcc94713deb5412873a3fd5efb27574899d3f.
Updated by Gerrit Code Review over 6 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57283
Updated by Mathias Brodala over 6 years ago
- Status changed from Under Review to Resolved
Applied in changeset c2bd08199301a2e9421843f5b6f73f9e3364ffa9.
Updated by