Bug #79094

Extension Manager API potentially makes destructive database schema changes

Added by Helmut Hummel almost 5 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Extension Manager
Target version:
-
Start date:
2016-12-25
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

Szenario:

An extension (ext_test) changes the schema for table pages by increasing the field size of author_email to varchar(255). The core extension defines a size of varchar(80) for this field.

Steps to reproduce:
  • when I install the extension using the extension manager
  • and execute the command on command line typo3/cli_dispatch.phpsh extbase extension:install core

Expected result:
I expect the database schema to not have changed

Actual result:
The field size of author_email in table pagesis reduced to varchar(80)
This can be verified in the install tool with the database compare tool


Files

ext_test_0.1.0_201701132110.zip (615 Bytes) ext_test_0.1.0_201701132110.zip Extension 1 Helmut Hummel, 2017-01-13 21:12
ext_test1_0.1.0_201701132111.zip (598 Bytes) ext_test1_0.1.0_201701132111.zip Extension 2 (depends on Extension 1) Helmut Hummel, 2017-01-13 21:12

Related issues

Related to TYPO3 Core - Task #83986: Streamline size of all email fields at the database schemaClosed2018-02-20

Actions
Precedes TYPO3 Core - Bug #85915: Exception on attempt to update a static database table in extension managerClosed

Actions
#1

Updated by Helmut Hummel almost 5 years ago

  • Category set to Extension Manager
  • Assignee set to Nicole Cordes
#2

Updated by Helmut Hummel almost 5 years ago

  • Status changed from New to Accepted
#3

Updated by Helmut Hummel almost 5 years ago

  • File deleted (ext_test.zip)
#6

Updated by Helmut Hummel almost 5 years ago

This bug is even easier to trigger:

  1. Install both extensions
  2. On database level add a long string to table "pages" in field "tx_ext_test"
  3. Re-upload ext_test and confirm overwrite

Expected result: Data in tx_ext_test is fine

Actual result: Data in tx_ext_test is truncated to 10 characters

#7

Updated by Guido S. over 3 years ago

  • Related to Task #83986: Streamline size of all email fields at the database schema added
#8

Updated by Gerrit Code Review over 3 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57429

#9

Updated by Gerrit Code Review over 3 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57429

#10

Updated by Gerrit Code Review over 3 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57429

#11

Updated by Gerrit Code Review over 3 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57429

#12

Updated by Gerrit Code Review over 3 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57429

#13

Updated by Gerrit Code Review over 3 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57429

#14

Updated by Gerrit Code Review over 3 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57429

#15

Updated by Gerrit Code Review over 3 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57429

#16

Updated by Gerrit Code Review over 3 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57429

#17

Updated by Gerrit Code Review over 3 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57429

#18

Updated by Nicole Cordes over 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#19

Updated by Gerrit Code Review over 3 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57486

#20

Updated by Gerrit Code Review over 3 years ago

Patch set 2 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57486

#21

Updated by Nicole Cordes over 3 years ago

  • Status changed from Under Review to Resolved
#22

Updated by Stephan Großberndt about 3 years ago

  • Precedes Bug #85915: Exception on attempt to update a static database table in extension manager added
#23

Updated by Benni Mack about 3 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF