Project

General

Profile

Actions
Copy link

Task #79515

closed

Wrap doesRecordExist in new method

Added by Thomas Hohn about 7 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Thomas Hohn
Category:
-
Target version:
Candidate for patchlevel
Start date:
2017-01-27
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
7.0
Tags:
Complexity:
Sprint Focus:
Stabilization Sprint

Description

At several places in the Datahandler class a call to doesRecordExist is followed immediately
with at call to BackendUtility::getRecordWSOL which then fetches the record.
Instead we wrap the functionality from doesRecordExist into a new method that returns
the row - with all the permissions checks performed.
Instead of calling BackendUtility::getRecordWSOL we add a new method
recordInfoWithPermissionCheck which returns the row instead of just true/false if
the record exists and is accessible. Afterwards the row is processed with a new method
getRecordWSOLWithRow which processes the just newly processed row.

The makes the flow simpler and saves an saves an sql-query - which will give a performance
enhancement when copying big sub-trees in the TYPO3 backend.

Related issues 1 (0 open — 1 closed)

Related to TYPO3 Core - Bug #81747: Copying workspace version record failsClosed2017-06-29

Actions
Actions
Copy link
 #1

Updated by Gerrit Code Review about 7 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51447

Actions
Copy link
 #2

Updated by Gerrit Code Review about 7 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51447

Actions
Copy link
 #3

Updated by Gerrit Code Review about 7 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51447

Actions
Copy link
 #4

Updated by Gerrit Code Review about 7 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51447

Actions
Copy link
 #5

Updated by Gerrit Code Review about 7 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51447

Actions
Copy link
 #6

Updated by Gerrit Code Review about 7 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51447

Actions
Copy link
 #7

Updated by Gerrit Code Review about 7 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51447

Actions
Copy link
 #8

Updated by Gerrit Code Review about 7 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51447

Actions
Copy link
 #9

Updated by Gerrit Code Review about 7 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51447

Actions
Copy link
 #10

Updated by Gerrit Code Review about 7 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51447

Actions
Copy link
 #11

Updated by Gerrit Code Review about 7 years ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51447

Actions
Copy link
 #12

Updated by Gerrit Code Review about 7 years ago

Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51447

Actions
Copy link
 #13

Updated by Gerrit Code Review about 7 years ago

Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51447

Actions
Copy link
 #14

Updated by Gerrit Code Review about 7 years ago

Patch set 14 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51447

Actions
Copy link
 #15

Updated by Gerrit Code Review about 7 years ago

Patch set 15 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51447

Actions
Copy link
 #16

Updated by Gerrit Code Review about 7 years ago

Patch set 16 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51447

Actions
Copy link
 #17

Updated by Gerrit Code Review about 7 years ago

Patch set 17 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51447

Actions
Copy link
 #18

Updated by Gerrit Code Review about 7 years ago

Patch set 18 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51447

Actions
Copy link
 #19

Updated by Gerrit Code Review about 7 years ago

Patch set 19 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51447

Actions
Copy link
 #20

Updated by Gerrit Code Review about 7 years ago

Patch set 20 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51447

Actions
Copy link
 #21

Updated by Gerrit Code Review about 7 years ago

Patch set 21 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51447

Actions
Copy link
 #22

Updated by Gerrit Code Review about 7 years ago

Patch set 22 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51447

Actions
Copy link
 #23

Updated by Gerrit Code Review about 7 years ago

Patch set 23 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51447

Actions
Copy link
 #24

Updated by Gerrit Code Review about 7 years ago

Patch set 24 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51447

Actions
Copy link
 #25

Updated by Thomas Hohn about 7 years ago

  • Subject changed from SQL queries can be avoided in DataHandler::doesRecordExist to Wrap doesRecordExist in new method
  • Description updated (diff)
  • PHP Version set to 7.0
Actions
Copy link
 #26

Updated by Gerrit Code Review about 7 years ago

Patch set 25 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51447

Actions
Copy link
 #27

Updated by Gerrit Code Review about 7 years ago

Patch set 26 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51447

Actions
Copy link
 #28

Updated by Gerrit Code Review about 7 years ago

Patch set 27 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51447

Actions
Copy link
 #29

Updated by Gerrit Code Review about 7 years ago

Patch set 28 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51447

Actions
Copy link
 #30

Updated by Gerrit Code Review about 7 years ago

Patch set 29 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51447

Actions
Copy link
 #31

Updated by Gerrit Code Review about 7 years ago

Patch set 30 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51447

Actions
Copy link
 #32

Updated by Gerrit Code Review about 7 years ago

Patch set 31 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51447

Actions
Copy link
 #33

Updated by Gerrit Code Review about 7 years ago

Patch set 32 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51447

Actions
Copy link
 #34

Updated by Gerrit Code Review about 7 years ago

Patch set 33 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51447

Actions
Copy link
 #35

Updated by Gerrit Code Review about 7 years ago

Patch set 34 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51447

Actions
Copy link
 #36

Updated by Benni Mack about 7 years ago

  • Target version changed from 8.6 to 8 LTS
Actions
Copy link
 #37

Updated by Thomas Hohn about 7 years ago

  • Sprint Focus set to Stabilization Sprint
Actions
Copy link
 #38

Updated by Gerrit Code Review about 7 years ago

Patch set 35 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51447

Actions
Copy link
 #39

Updated by Gerrit Code Review about 7 years ago

Patch set 36 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51447

Actions
Copy link
 #40

Updated by Gerrit Code Review about 7 years ago

Patch set 37 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51447

Actions
Copy link
 #41

Updated by Gerrit Code Review about 7 years ago

Patch set 38 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51447

Actions
Copy link
 #42

Updated by Gerrit Code Review about 7 years ago

Patch set 39 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51447

Actions
Copy link
 #43

Updated by Gerrit Code Review about 7 years ago

Patch set 40 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51447

Actions
Copy link
 #44

Updated by Gerrit Code Review about 7 years ago

Patch set 41 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51447

Actions
Copy link
 #45

Updated by Gerrit Code Review about 7 years ago

Patch set 42 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51447

Actions
Copy link
 #46

Updated by Gerrit Code Review about 7 years ago

Patch set 43 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51447

Actions
Copy link
 #47

Updated by Gerrit Code Review about 7 years ago

Patch set 44 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51447

Actions
Copy link
 #48

Updated by Benni Mack about 7 years ago

  • Target version changed from 8 LTS to Candidate for patchlevel
Actions
Copy link
 #49

Updated by Gerrit Code Review about 7 years ago

Patch set 45 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51447

Actions
Copy link
 #50

Updated by Gerrit Code Review about 7 years ago

Patch set 46 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51447

Actions
Copy link
 #51

Updated by Gerrit Code Review almost 7 years ago

Patch set 47 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51447

Actions
Copy link
 #52

Updated by Kasper Ligaard almost 7 years ago

The positive effect of fixing this is documented in https://docs.google.com/presentation/d/1Pcm8H2nJD_dyj9tqwkXkcKYbCRVCGGFFfk_gVnDhQ5g/edit#slide=id.g1cbe49000b_0_91, which was presented at the TYPO3 Code Sprint in late February 2017.

Actions
Copy link
 #53

Updated by Gerrit Code Review almost 7 years ago

Patch set 48 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51447

Actions
Copy link
 #54

Updated by Gerrit Code Review almost 7 years ago

Patch set 49 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51447

Actions
Copy link
 #55

Updated by Gerrit Code Review almost 7 years ago

Patch set 50 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51447

Actions
Copy link
 #56

Updated by Gerrit Code Review almost 7 years ago

Patch set 51 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51447

Actions
Copy link
 #57

Updated by Gerrit Code Review almost 7 years ago

Patch set 52 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51447

Actions
Copy link
 #58

Updated by Gerrit Code Review almost 7 years ago

Patch set 53 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51447

Actions
Copy link
 #59

Updated by Gerrit Code Review almost 7 years ago

Patch set 54 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51447

Actions
Copy link
 #60

Updated by Thomas Hohn almost 7 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #61

Updated by Gerrit Code Review almost 7 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53266

Actions
Copy link
 #62

Updated by Gerrit Code Review almost 7 years ago

Patch set 2 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53266

Actions
Copy link
 #63

Updated by Gerrit Code Review almost 7 years ago

Patch set 3 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53266

Actions
Copy link
 #64

Updated by Thomas Hohn almost 7 years ago

  • Status changed from Under Review to Resolved
Actions
Copy link
 #65

Updated by Oliver Hader almost 7 years ago

  • Related to Bug #81747: Copying workspace version record fails added
Actions
Copy link
 #66

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF