Task #80393
closed
EXT:form - Streamline fluid namespace in templates
100%
Description
Hi,
it's a bit of an personal taste, but I prefer xmlns-Namespace definitions over {namespace}.
My IDE (PhpStorm) shouts a lot warnings at me if a look into templates within EXT:form.
I would suggest to streamline the fluid namespaces to match f.e. EXT:fluid_styled_content[[https://github.com/TYPO3/TYPO3.CMS/blob/master/typo3/sysext/fluid_styled_content/Resources/Private/Partials/Media/Gallery.html]], like:
<html xmlns:f="http://typo3.org/ns/TYPO3/CMS/Fluid/ViewHelpers" xmlns:formvh="http://typo3.org/ns/TYPO3/CMS/Form/ViewHelpers" data-namespace-typo3-fluid="true">
Maybe could discuss this?
Regards
David
Updated by David Gurk over 7 years ago
Note: I'm currently not on dev-master but on 8.6.1.
In dev-master the templates haven't a {namespace formvh=TYPO3\CMS\Form\ViewHelpers} at all.
Updated by Ralf Zimmermann over 7 years ago
No namespaces exists in current master within the fluid templates.
You are using 8.6.1.
This issue is more like "add '<html xmlns...' stuff to the templates to make it IDE compatible".
I heared that @Benjamin Kott want's to streamline the templates. But not sure.
Updated by Gerrit Code Review over 7 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52121
Updated by Gerrit Code Review over 7 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52121
Updated by Gerrit Code Review over 7 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52121
Updated by Gerrit Code Review over 7 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52121
Updated by Gerrit Code Review over 7 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52121
Updated by Anonymous over 7 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset c50d776a57f659052782e3464f76a8dc0c52c65a.
Updated by Riccardo De Contardi about 7 years ago
- Status changed from Resolved to Closed