Project

General

Profile

Actions

Feature #81330

closed

Provide a path to migrate internal class properties to protected

Added by Elmar Hinz almost 7 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Code Cleanup
Target version:
Start date:
2017-05-24
Due date:
% Done:

100%

Estimated time:
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

A lot of properties of core classes are public since years, making it hard to refactor the classes. Every change is threatening to break extensions. This slows down the modernisation of TYPO3 a lot.

A path is needed to be able to set public properties to protected without immediately breaking extensions. This is generally reached by deprecation and period of transition to adjust extensions.

Deprecation works well for methods, as they can trigger the deprecation log directly. Provide this feature for properties, by triggering the depreciation log by using magic accessor methods to trigger the log.

Suggestion is to use a trait to temporarily include the feature into classes for periods of transition.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Feature #85247: Add trait to detect public deprecated methodsClosed2018-06-12

Actions
Actions #1

Updated by Gerrit Code Review almost 7 years ago

  • Status changed from New to Under Review

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52928

Actions #2

Updated by Gerrit Code Review almost 7 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52928

Actions #3

Updated by Gerrit Code Review almost 7 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52928

Actions #4

Updated by Gerrit Code Review almost 7 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52928

Actions #5

Updated by Gerrit Code Review almost 7 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52928

Actions #6

Updated by Gerrit Code Review almost 7 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52928

Actions #7

Updated by Gerrit Code Review almost 7 years ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52928

Actions #8

Updated by Gerrit Code Review almost 7 years ago

Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52928

Actions #9

Updated by Gerrit Code Review almost 7 years ago

Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52928

Actions #10

Updated by Gerrit Code Review almost 7 years ago

Patch set 14 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52928

Actions #11

Updated by Gerrit Code Review almost 7 years ago

Patch set 15 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52928

Actions #12

Updated by Gerrit Code Review almost 7 years ago

Patch set 16 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52928

Actions #13

Updated by Gerrit Code Review almost 7 years ago

Patch set 17 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52928

Actions #14

Updated by Gerrit Code Review almost 7 years ago

Patch set 18 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52928

Actions #15

Updated by Gerrit Code Review almost 7 years ago

Patch set 19 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52928

Actions #16

Updated by Gerrit Code Review almost 7 years ago

Patch set 20 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52928

Actions #17

Updated by Gerrit Code Review almost 7 years ago

Patch set 21 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52928

Actions #18

Updated by Gerrit Code Review almost 7 years ago

Patch set 22 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52928

Actions #19

Updated by Gerrit Code Review almost 7 years ago

Patch set 23 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52928

Actions #20

Updated by Gerrit Code Review almost 7 years ago

Patch set 24 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52928

Actions #21

Updated by Gerrit Code Review almost 7 years ago

Patch set 25 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52928

Actions #22

Updated by Gerrit Code Review almost 7 years ago

Patch set 26 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52928

Actions #23

Updated by Gerrit Code Review almost 7 years ago

Patch set 27 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52928

Actions #24

Updated by Gerrit Code Review almost 7 years ago

Patch set 28 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52928

Actions #25

Updated by Gerrit Code Review almost 7 years ago

Patch set 29 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52928

Actions #26

Updated by Gerrit Code Review over 6 years ago

Patch set 30 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52928

Actions #27

Updated by Gerrit Code Review over 6 years ago

Patch set 31 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52928

Actions #28

Updated by Gerrit Code Review over 6 years ago

Patch set 32 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52928

Actions #29

Updated by Gerrit Code Review over 6 years ago

Patch set 33 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52928

Actions #30

Updated by Elmar Hinz over 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #31

Updated by Daniel Goerz about 6 years ago

  • Related to Bug #84649: Opening the newContentElementWizard triggers Deprecation Error added
Actions #32

Updated by Anja Leichsenring about 6 years ago

  • Related to deleted (Bug #84649: Opening the newContentElementWizard triggers Deprecation Error)
Actions #33

Updated by Christian Kuhn almost 6 years ago

  • Related to Feature #85247: Add trait to detect public deprecated methods added
Actions #34

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF