Bug #81340
closedTemplatePaths::fillDefaultsByPackageName does not sort paths correctly
100%
Description
The unfortunate series of events which lead to a problem:
- TemplatePaths->fillDefaultsByPackageName($extKey) gets called
- TemplatePaths->fillDefaultSByPackageName() calls getContextSpecificViewConfiguration()
- TemplatePaths->getContextSpecificViewConfiguration() reads TS and returns combined fallback paths and TS-configured paths
- TemplatePaths->fillFromConfigurationArray($resolvedPaths) gets called
- TemplatePaths->fillFromConfigurationArray() calls TemplatePaths->extractPathArrays()
- TemplatePaths->extractPathArrays() calls array_values
Result: when calling fillDefaultsByPackageName() TS paths do not get sorted correctly even though the right setTemplateRootPaths and so on get called. Normally these methods would indeed sort the paths correctly, but the array_values() part (Fluid standalone cares about order, not keys) causes the methods that do perform sorting, to receive an "already sorted" (=values only, numeric zero-index in order TS was declared) which of course does not get sorted further. Final result is that template overrides do not work if View was initialised with this method - which by the way should be the preferred way to initialise View template paths everywhere in TYPO3.
Updated by Gerrit Code Review over 7 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52938
Updated by Gerrit Code Review over 7 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52938
Updated by Gerrit Code Review over 7 years ago
Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53112
Updated by Anonymous over 7 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 4508c537ad8a892f5a12c08f1a6ab5926015d8c6.
Updated by Xavier Perseguers over 7 years ago
- Precedes Bug #81677: TYPO3 Exception "Section "main" does not exist." under TYPO3 8.7.2 added
Updated by Gerrit Code Review over 7 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53310
Updated by Claus Due about 7 years ago
- Status changed from Under Review to Resolved
Merge event was not caught by Redmine. This one is solved :)