Bug #81591

Translation of email finisher subject

Added by Wolfgang Freund 2 months ago. Updated about 1 month ago.

Status:
Under Review
Priority:
Should have
Category:
Form Framework
Target version:
-
Start date:
2017-06-16
Due date:
% Done:

0%

TYPO3 Version:
8
PHP Version:
7.1
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Hi there,

as stated in the documentation here:
https://docs.typo3.org/typo3cms/drafts/code.tritum.de/TYPO3.CMS/Form_Documentation/Concepts/Index.html#concepts-frontendrendering-translation-finishers

the subject of the email finishers should translatable via:

<!-- Form Finishers -->
            <trans-unit id="finisher.EmailToReceiver.subject">
                <source>My own receiver subject</source>
            </trans-unit>
            <trans-unit id="finisher.EmailToSender.subject">
                <source>My own sender subject</source>
            </trans-unit>

But is still uses the default subject used in the YAML-File:

finishers:
  -
    identifier: EmailToReceiver
    options:
      subject: 'Message from website'
      recipientAddress: test@test.com
      recipientName: 'Testname'
      senderAddress: noreply@test.com
      senderName: '{firstname} {lastname}'
      replyToAddress: '{email}'
      carbonCopyAddress: ''
      blindCarbonCopyAddress: ''
      format: html
      attachUploads: 'false'
      translation:
        language: 'en'
  -
    identifier: EmailToSender
    options:
      subject: 'Thank you for your mail'
      recipientAddress: '{email}'
      recipientName: ''
      senderAddress: noreply@test.com
      senderName: 'Testname'
      replyToAddress: ''
      carbonCopyAddress: ''
      blindCarbonCopyAddress: ''
      format: html
      attachUploads: 'false'

History

#1 Updated by Gerrit Code Review about 2 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53363

#2 Updated by Ralf Zimmermann about 2 months ago

  • Assignee set to Ralf Zimmermann

You are right. There is a bug. For now, the translation key is calculated from the finisher implementation class name (like EmailFinisher) without the "Finisher" suffix.
This is why a translation keys like "finisher.EmailToReceiver.subject" won't work because EXT:form searches for "finisher.Email.subject" (the implementation class name ist called EmailFinisher.php).

#3 Updated by Gerrit Code Review about 1 month ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53363

Also available in: Atom PDF