Project

General

Profile

Actions

Bug #82252

closed

Typoscript formDefinitionOverrides do override the Flexform setting overrides

Added by Denis Mir over 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Form Framework
Target version:
-
Start date:
2017-08-31
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
7.1
Tags:
Complexity:
easy
Is Regression:
Sprint Focus:
On Location Sprint

Description

We are using the typoscript "formDefinitionOverrides" to be able to set form definition settings depending on the current environment and language.

This does work fine and looks like this:

plugin.tx_form {
  settings {
    formDefinitionOverrides {
      ContactForm {
        finishers {
          0 {
            options {
              recipientAddress = {$plugin.configuration.site.extensions.form.contact.recipientAddress}
            }
          }
        }
      }
    }
  }
}

But it should be possible to override these settings by the flexform finisher overrides. Unfortunately the ordering in the "FormFrontendController" makes this impossible:

            $formDefinition = $this->formPersistenceManager->load($this->settings['persistenceIdentifier']);
            $formDefinition['persistenceIdentifier'] = $this->settings['persistenceIdentifier'];
            $formDefinition = $this->overrideByFlexFormSettings($formDefinition);
            $formDefinition = $this->overrideByTypoScriptSettings($formDefinition);

It doesn't make sense to override flexform settings by typoscript settings. In my opinion (formhandler worked the same way) the flexform settings should be the most important setting.

Actions

Also available in: Atom PDF