Bug #82291

Pasting of already deleted records should not be possible

Added by Filipe DA COSTA COSTA about 2 years ago. Updated over 1 year ago.

Status:
New
Priority:
Should have
Assignee:
-
Category:
DataHandler aka TCEmain
Target version:
-
Start date:
2017-09-04
Due date:
% Done:

0%

TYPO3 Version:
8
PHP Version:
7.1
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

In the case where you have multiple people working on content or multiple tabs open, it's possible to paste a CE that was already deleted.

This can leads to problems in extensions that do not expect to be called by the "processCmdmap_postProcess" hook.

For example, this leads to an issue with Flux where the "sorting" of copied content get's messed up.

History

#1 Updated by Filipe DA COSTA COSTA about 2 years ago

An example of a possible problem can be found here : https://github.com/FluidTYPO3/flux/issues/1457

#2 Updated by Oliver Hader over 1 year ago

  • Status changed from New to Needs Feedback

Can you please provide the required steps in order to reproduce this behavior?
Or is it about the copy command to checking whether a record has been deleted? If so, this should be reproducible in a new functional test case...

#3 Updated by Filipe DA COSTA COSTA over 1 year ago

Oliver Hader wrote:

Can you please provide the required steps in order to reproduce this behavior?
Or is it about the copy command to checking whether a record has been deleted? If so, this should be reproducible in a new functional test case...

Yes, it's about he copy command. It get's executed without checking if the record is deleted.

How you can reproduce the "processCmdmap_postProcess" on a deleted record:

- Open a first Tab A and copy a CE
- Open a second Tab B. The "Paste" button should be present
- In Tab A remove de CE
- Return to Tab B and "paste" the CE by pressing the button

DataHandler:process_cmdmap is called and a "copy" command is executed.

After this, the "processCmdmap_postProcess" hook is triggered but with an empty "$this->copyMappingArray" what caused the problem in flux.

As of today, this issue was fixed in flux, but the maintainer asked me to open a ticket anyway as he thinks that the hook should not be called in the first place.

#4 Updated by Riccardo De Contardi over 1 year ago

  • Status changed from Needs Feedback to New

Also available in: Atom PDF