Bug #82291
open
Pasting of already deleted records should not be possible
0%
Description
In the case where you have multiple people working on content or multiple tabs open, it's possible to paste a CE that was already deleted.
This can leads to problems in extensions that do not expect to be called by the "processCmdmap_postProcess" hook.
For example, this leads to an issue with Flux where the "sorting" of copied content get's messed up.
Updated by Filipe DA COSTA COSTA almost 7 years ago
An example of a possible problem can be found here : https://github.com/FluidTYPO3/flux/issues/1457
Updated by Oliver Hader over 6 years ago
- Status changed from New to Needs Feedback
Can you please provide the required steps in order to reproduce this behavior?
Or is it about the copy command to checking whether a record has been deleted? If so, this should be reproducible in a new functional test case...
Updated by Filipe DA COSTA COSTA over 6 years ago
Oliver Hader wrote:
Can you please provide the required steps in order to reproduce this behavior?
Or is it about thecopycommand to checking whether a record has been deleted? If so, this should be reproducible in a new functional test case...
Yes, it's about he copy command. It get's executed without checking if the record is deleted.
How you can reproduce the "processCmdmap_postProcess" on a deleted record:
- Open a first Tab A and copy a CE
- Open a second Tab B. The "Paste" button should be present
- In Tab A remove de CE
- Return to Tab B and "paste" the CE by pressing the button
DataHandler:process_cmdmap is called and a "copy" command is executed.
After this, the "processCmdmap_postProcess" hook is triggered but with an empty "$this->copyMappingArray" what caused the problem in flux.
As of today, this issue was fixed in flux, but the maintainer asked me to open a ticket anyway as he thinks that the hook should not be called in the first place.
Updated by Riccardo De Contardi about 6 years ago
- Status changed from Needs Feedback to New
Updated by Riccardo De Contardi about 1 month ago
· Edited
Sorry for having picked up this one after so long time.
I don't know what behavior should be expected: This is the test I performed on 13.2.0-dev (latest master)
1. Open TYPO3 backend; go to a page "Test", create in it a CE (e.g. CType "Headline") with headline "To be copied"
2. On page module, click on the three dots icon and select "Copy" from the context menu => the "paste icons" on the page sections become visible (OK)
3. Open a new browser tab with the same TYPO3 backend and go to another page => the "paste icons" are still visible (OK)
4. Go to the first tab and delete the content element => the "paste icons" disappear
5. Go to the second tab; the "paste icons" are still present
6. click on one of the paste icon
Result¶
1. Nothing is copied, the copy simply does not do anything
2. the deleted CE is listed on the Recycler module, and its pid is the one of the original page
What would be the expected behavior? Am I missing something? Should a different test be performed?
Updated by Garvin Hicking about 1 month ago
- Status changed from New to Needs Feedback