Feature #82348

Remove static icon array from IconRegistry

Added by Patricia Tiedemann about 2 years ago. Updated 12 months ago.

Status:
Closed
Priority:
Could have
Category:
Backend API
Target version:
-
Start date:
2017-09-07
Due date:
% Done:

100%

PHP Version:
Tags:
Complexity:
medium
Sprint Focus:
On Location Sprint

Description

Nice to have thing:
Currently the BE icons are a manually updated array in the IconRegistry.
Instead, the initializer should run through definded folders to fetch all actually existing icons and render them into a serialized array which will be cached and returned on next call.


Related issues

Related to TYPO3 Core - Bug #83979: Avoid registering extension icons in IconRegistry Closed 2018-02-20

Associated revisions

Revision f4de6926 (diff)
Added by Patricia Tiedemann about 2 years ago

[TASK] Render backend icon list by existing files

Until now all of the backend icons were a manually edited array of file
paths. With this patch defined icon folders in the core are scanned
for existing icon files and build most of that static array
automatically.

For historic reason (and hopefully soon to be removed alltogether) a
second array of statically declared icons is added and merged into.

Some icons that were in the original static list but whose files
actually are missing or misnamed are marked as deprecated.

Resolves: #82348
Releases: master
Change-Id: I8dc4fbbe815d923eda55e1c1b072369e62f66d87
Reviewed-on: https://review.typo3.org/54020
Reviewed-by: Benjamin Kott <>
Tested-by: Benjamin Kott <>
Reviewed-by: Andreas Fernandez <>
Tested-by: Andreas Fernandez <>

Revision da02c56a (diff)
Added by Patricia Tiedemann about 2 years ago

[FOLLOWUP][TASK] Render backend icon list by existing files

  • Re-added the "spinning" option for spinners (thx Nathan)
  • Changed cache from backend_core to asset (thx @helhum)

Resolves: #82348
Releases: master
Change-Id: I1e59da79dc7072b582866213a571e35bfee4b639
Reviewed-on: https://review.typo3.org/54061
Reviewed-by: Stefan Neufeind <>
Tested-by: Stefan Neufeind <>
Tested-by: TYPO3com <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>

History

#1 Updated by Jan Helke about 2 years ago

  • Status changed from New to In Progress

#2 Updated by Gerrit Code Review about 2 years ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54020

#3 Updated by Gerrit Code Review about 2 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54020

#4 Updated by Gerrit Code Review about 2 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54020

#5 Updated by Gerrit Code Review about 2 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54020

#6 Updated by Gerrit Code Review about 2 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54020

#7 Updated by Gerrit Code Review about 2 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54020

#8 Updated by Gerrit Code Review about 2 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54020

#9 Updated by Gerrit Code Review about 2 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54020

#10 Updated by Gerrit Code Review about 2 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54020

#11 Updated by Gerrit Code Review about 2 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54020

#12 Updated by Gerrit Code Review about 2 years ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54020

#13 Updated by Gerrit Code Review about 2 years ago

Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54020

#14 Updated by Gerrit Code Review about 2 years ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54061

#15 Updated by Gerrit Code Review about 2 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54061

#16 Updated by Patricia Tiedemann about 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#17 Updated by Gerrit Code Review about 2 years ago

  • Status changed from Resolved to Under Review

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54061

#18 Updated by Gerrit Code Review about 2 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54061

#19 Updated by Gerrit Code Review about 2 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54061

#20 Updated by Patricia Tiedemann about 2 years ago

  • Status changed from Under Review to Resolved

#21 Updated by Oliver Hader over 1 year ago

  • Related to Bug #83979: Avoid registering extension icons in IconRegistry added

#22 Updated by Benni Mack 12 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF