Task #82368

Move extension settings from extension manager to install tool

Added by Markus Hölzle about 2 years ago. Updated 12 months ago.

Status:
Closed
Priority:
Should have
Category:
Install Tool
Target version:
-
Start date:
2017-09-08
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:
On Location Sprint

Related issues

Related to TYPO3 Core - Feature #82254: Store extension configuration as plain array Closed 2017-08-31
Related to TYPO3 Core - Bug #83298: Install tool may fail if LocalConfiguration EXT/extConf does not exist Closed 2017-12-12
Related to TYPO3 Core - Bug #83300: bootstrap package can't be installed via distribution install Closed 2017-12-12
Related to TYPO3 Core - Bug #83319: Extension settings do not respect default values Closed 2017-12-14
Related to TYPO3 Core - Bug #87818: Extension manager installs extension NOT even if in the settings the checkbox is set Closed 2019-03-01

Associated revisions

Revision ebf0f1a7 (diff)
Added by Markus Hölzle almost 2 years ago

[!!!][FEATURE] Move extension configuration to install tool

With #82254 LocalConfiguration serialized array EXT/extConf has been
changed to a not serialized array in EXTENSIONS. This patch follows
up on this task an finishes various tasks:

  • An install tool silent upgrader upmerges given EXT/extConf settings
    to EXTENSIONS array. The resulting EXTENSIONS array does not contain
    dots for sub paths in its array key anymore and is accessible with a
    new ExtensionConfiguration->get() API to fetch values and whole
    extension config.
  • A new API is introduced to get() and set() extension specific
    configuration, is documented and used throughout the core to not
    unserialize old EXT/extConf anymore. Setting values updates legacy
    EXT/extConf to new values including compatible 'dot' ending on
    nested array configurations.
  • If extensions come with new configuration items in ext_conf_template.txt
    a silent upgrader of the install tool synchronizes these to the
    EXTENSIONS and old extConf array. Extension authors can rely on that
    and always fetch new keys from the new ExtensionConfiguration->get()
    API right away. The synchronization is also triggered when new
    extensions are loaded or extensions are updated via the extension
    manager.
  • Core usages are adapted to the new API.
  • Next to the main get() / set() API, the extension configuration
    form is extracted from the extension manager and put into the install
    tool as a new card in "Settings". The code below is streamlined
    and encapsulated with just a couple of public methods in class
    'ExtensionConfigurationService' as internal class for use in install
    tool and extension manager.

Resolves: #82368
Related: #82254
Releases: master
Change-Id: I88568fa355f8f6fd5acc9850dcdd718fdd9a1b2e
Reviewed-on: https://review.typo3.org/54034
Tested-by: TYPO3com <>
Reviewed-by: Daniel Gorges <>
Tested-by: Daniel Gorges <>
Reviewed-by: Andreas Fernandez <>
Reviewed-by: Benni Mack <>
Tested-by: Benni Mack <>

Revision 357547db (diff)
Added by Susanne Moog almost 2 years ago

[BUGFIX] Repopulate localconfig before cache reload in ext mgr

Reloading caches requires the ext_localconf files. If in an
ext_localconf the extension configuration is accessed this
will fail directly after installation as the configuration is
not reloaded yet.

The patch changes the order to first write the new configuration,
then read the new configuration into the global array and
finally reloading the caches.

Change-Id: I9e2cd70078b2038aa30f2b4706aec46243ab2a9d
Resolves: #83300
Related: #82368
Releases: master
Reviewed-on: https://review.typo3.org/55045
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>
Reviewed-by: Stefan Neufeind <>
Tested-by: Stefan Neufeind <>

Revision bbe45c69 (diff)
Added by Christian Kuhn almost 2 years ago

[TASK] Install tool fails if LocalConfiguration EXT/extConf does not exist

On fresh instances, the install tool may fail if path EXT/extConf
which is written as b/w compat layer does not exist, yet.
Patch catches the (generic) exception from ArrayUtility->getValueByPath()
and initializes the value to an empty array to continue in this case.

Resolves: #83298
Related: #82368
Releases: master
Change-Id: Iffac458a9e42183139ab4425082abb6f78944ffd
Reviewed-on: https://review.typo3.org/55044
Tested-by: TYPO3com <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>
Reviewed-by: Susanne Moog <>
Tested-by: Susanne Moog <>

Revision 56e4ade4 (diff)
Added by Andreas Fernandez 5 months ago

[BUGFIX] Check correct setting on extension upload

With #82368, the Configuration API is used in the Extension Manager to
check specific configuration.

However, for automatic extension installation the wrong setting was
checked. This patch now uses the correct setting, fixing an issue with
extensions not getting installed after upload.

Resolves: #87818
Related: #82368
Releases: master, 9.5
Change-Id: If18e96c4c17d06723805b4dd6c8807adabe19966
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60625
Tested-by: TYPO3com <>
Tested-by: Susanne Moog <>
Tested-by: Guido Schmechel <>
Tested-by: Andreas Fernandez <>
Reviewed-by: Susanne Moog <>
Reviewed-by: Guido Schmechel <>
Reviewed-by: Andreas Fernandez <>

Revision b355c8fc (diff)
Added by Andreas Fernandez 5 months ago

[BUGFIX] Check correct setting on extension upload

With #82368, the Configuration API is used in the Extension Manager to
check specific configuration.

However, for automatic extension installation the wrong setting was
checked. This patch now uses the correct setting, fixing an issue with
extensions not getting installed after upload.

Resolves: #87818
Related: #82368
Releases: master, 9.5
Change-Id: If18e96c4c17d06723805b4dd6c8807adabe19966
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60652
Tested-by: TYPO3com <>
Tested-by: Andreas Fernandez <>
Reviewed-by: Andreas Fernandez <>

History

#1 Updated by Gerrit Code Review about 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54030

#2 Updated by Gerrit Code Review about 2 years ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54034

#3 Updated by Gerrit Code Review about 2 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54034

#4 Updated by Gerrit Code Review about 2 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54034

#5 Updated by Gerrit Code Review about 2 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54034

#6 Updated by Gerrit Code Review about 2 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54034

#7 Updated by Gerrit Code Review about 2 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54034

#8 Updated by Gerrit Code Review almost 2 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54034

#9 Updated by Gerrit Code Review almost 2 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54034

#10 Updated by Gerrit Code Review almost 2 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54034

#11 Updated by Gerrit Code Review almost 2 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54034

#12 Updated by Gerrit Code Review almost 2 years ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54034

#13 Updated by Gerrit Code Review almost 2 years ago

Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54034

#14 Updated by Gerrit Code Review almost 2 years ago

Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54034

#15 Updated by Gerrit Code Review almost 2 years ago

Patch set 14 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54034

#16 Updated by Christian Kuhn almost 2 years ago

  • Related to Feature #82254: Store extension configuration as plain array added

#17 Updated by Gerrit Code Review almost 2 years ago

Patch set 15 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54034

#18 Updated by Gerrit Code Review almost 2 years ago

Patch set 16 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54034

#19 Updated by Gerrit Code Review almost 2 years ago

Patch set 17 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54034

#20 Updated by Gerrit Code Review almost 2 years ago

Patch set 18 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54034

#21 Updated by Gerrit Code Review almost 2 years ago

Patch set 19 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54034

#22 Updated by Gerrit Code Review almost 2 years ago

Patch set 20 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54034

#23 Updated by Gerrit Code Review almost 2 years ago

Patch set 21 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54034

#24 Updated by Gerrit Code Review almost 2 years ago

Patch set 22 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54034

#25 Updated by Gerrit Code Review almost 2 years ago

Patch set 23 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54034

#26 Updated by Gerrit Code Review almost 2 years ago

Patch set 24 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54034

#27 Updated by Gerrit Code Review almost 2 years ago

Patch set 25 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54034

#28 Updated by Gerrit Code Review almost 2 years ago

Patch set 26 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54034

#29 Updated by Gerrit Code Review almost 2 years ago

Patch set 27 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54034

#30 Updated by Gerrit Code Review almost 2 years ago

Patch set 28 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54034

#31 Updated by Gerrit Code Review almost 2 years ago

Patch set 29 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54034

#32 Updated by Gerrit Code Review almost 2 years ago

Patch set 30 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54034

#33 Updated by Gerrit Code Review almost 2 years ago

Patch set 31 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54034

#34 Updated by Gerrit Code Review almost 2 years ago

Patch set 32 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54034

#35 Updated by Gerrit Code Review almost 2 years ago

Patch set 33 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54034

#36 Updated by Markus Hölzle almost 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#37 Updated by Christian Kuhn almost 2 years ago

  • Related to Bug #83298: Install tool may fail if LocalConfiguration EXT/extConf does not exist added

#38 Updated by Susanne Moog almost 2 years ago

  • Related to Bug #83300: bootstrap package can't be installed via distribution install added

#39 Updated by Susanne Moog almost 2 years ago

  • Related to Bug #83319: Extension settings do not respect default values added

#40 Updated by Benni Mack 12 months ago

  • Status changed from Resolved to Closed

#41 Updated by Andreas Fernandez 5 months ago

  • Related to Bug #87818: Extension manager installs extension NOT even if in the settings the checkbox is set added

Also available in: Atom PDF