Task #82453

Extbase LocalizationUtility error feedback and logic can be improved

Added by Claus Due 15 days ago. Updated 15 days ago.

Status:
Under Review
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2017-09-11
Due date:
% Done:

0%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Two things should be done:

1. Early return should be done if $key is empty (won't matter if $extensionName or others are passed in this case - empty key equals null return value)
2. Failure to format with vsprintf should output a gentle message about the translation failure which includes the original string and the number of arguments being passed for easy comparison of marker and parameter counts.

History

#1 Updated by Gerrit Code Review 15 days ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54118

#2 Updated by Gerrit Code Review 15 days ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54118

#3 Updated by Gerrit Code Review 15 days ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54118

Also available in: Atom PDF