Task #82453

Extbase LocalizationUtility error feedback and logic can be improved

Added by Claus Due over 4 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Extbase
Target version:
-
Start date:
2017-09-11
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Two things should be done:

1. Early return should be done if $key is empty (won't matter if $extensionName or others are passed in this case - empty key equals null return value)
2. Failure to format with vsprintf should output a gentle message about the translation failure which includes the original string and the number of arguments being passed for easy comparison of marker and parameter counts.


Related issues

Related to TYPO3 Core - Bug #84149: Avoid associative array to be used in LocalizationUtilityClosed2018-03-06

Actions
#1

Updated by Gerrit Code Review over 4 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54118

#2

Updated by Gerrit Code Review over 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54118

#3

Updated by Gerrit Code Review over 4 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54118

#4

Updated by Susanne Moog over 4 years ago

  • Category set to Extbase
#5

Updated by Gerrit Code Review about 4 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54118

#6

Updated by Gerrit Code Review about 4 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54118

#7

Updated by Anonymous about 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#8

Updated by Oliver Hader about 4 years ago

  • Related to Bug #84149: Avoid associative array to be used in LocalizationUtility added
#9

Updated by Benni Mack over 3 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF