Bug #82498

getPagesTSconfigPreInclude signal must not alter pre cached PageTS

Added by Alexander Schnitzler almost 2 years ago. Updated about 1 year ago.

Status:
New
Priority:
Should have
Assignee:
-
Category:
Backend API
Start date:
2017-09-17
Due date:
% Done:

0%

TYPO3 Version:
9
PHP Version:
7.0
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

https://review.typo3.org/#/c/30921/ introduced the getPagesTSconfigPreInclude signal, which made altering the PageTS possible before it's cached.

Despite many arguments against introducing that signal there, it has been merged anyway. As a result, getPagesTSconfig is not indempotent any more and can create compromised PageTS cache entries.

Also the use of signals in that part of the core feels plain wrong as we rely on a mechanism brought by Extbase rather than using regular hooks like throughout the rest of the core.

Possible solution:
Instead of modifying the PageTS before it get's cached, I'd place the signal after the caching, making the cache entries indempotent.
We need to have a look at who is using that signal in what way and if modifying it must be considered breaking.


Related issues

Related to TYPO3 Core - Task #59703: Add hook to BackendUtility::getPagesTSconfig() Closed 2014-06-20
Related to TYPO3 Core - Task #82497: Streamline \TYPO3\CMS\Backend\Utility\BackendUtility::getPagesTSconfig Closed 2017-09-17

History

#1 Updated by Alexander Schnitzler almost 2 years ago

  • Related to Task #59703: Add hook to BackendUtility::getPagesTSconfig() added

#2 Updated by Alexander Schnitzler almost 2 years ago

  • Related to Task #82497: Streamline \TYPO3\CMS\Backend\Utility\BackendUtility::getPagesTSconfig added

#3 Updated by Susanne Moog over 1 year ago

  • Target version changed from 9.0 to 9.2

#4 Updated by Susanne Moog about 1 year ago

  • Target version changed from 9.2 to Candidate for patchlevel

Also available in: Atom PDF